-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks not running when user shell is fish #15421
Comments
When I attempt to run the "Example task" from zed.dev/docs/tasks I get the following: Which is expected because fish has a unique syntax for When I add I'm using the same version of fish you are (3.7.1) but my path is
|
Thanks a lot for the reply.
But when I added the resolved path After that, i have also tried:
None of these resolved the problem. Is there a way I can see debug messages for the entire application? |
hmmm very interesting. When i start zed with Screen.Recording.2024-07-29.at.4.35.04.PM.movalso, with v0.146.1-pre, task is runnable, but only when the shell is set to non-fish shells (tested with /bin/sh and /bin/zsh). |
All this much newer than I realized, those changes were added in Zed Preview v0.146.0 release 5 days ago.
Zed stable won't get this until Wednesday 2024-07-29, but the website docs match development immediately following merge -- we don't yet have a process for delayed release or version of docs. Please bear with us and thanks for reporting! Closing as duplicate of: #10964 |
Tasks is still not exactly working even with the preview version. Please check the video below, my task would only run when env is set. Screen.Recording.2024-07-29.at.6.03.38.PM.mov |
Check for existing issues
Describe the bug / provide steps to reproduce it
Bug description
Environment
Using fish, version 3.7.1 and Starship.
when running the example local "Example Task", and having the user default shell set to
/usr/local/bin/fish
, Zed would simply spawn a new shell and does nothing (actual task neither run or failed). Also, the following setting in tasks.json does not resovle the issue.After setting my default shell to /bin/sh or /bin/zsh, the task is running as expected. Upon checking the log and comparing log generated while fish is the dafault shell, I found that this line (or something similar)
2024-07-29T11:46:21.271502Z [INFO] updating SHELL environment variable to value from passwd entry: "/bin/zsh"
is not present.Environment
Zed: v0.145.1 (Zed)
OS: macOS 15.0.0
Memory: 16 GiB
Architecture: x86_64
If applicable, add mockups / screenshots to help explain present your vision of the feature
Screen.Recording.2024-07-29.at.8.00.39.AM.mov
Screen.Recording.2024-07-29.at.8.01.47.AM.mov
If applicable, attach your Zed.log file to this issue.
Zed.log
The text was updated successfully, but these errors were encountered: