Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename bitcoin.conf to zcash.conf #844

Closed
daira opened this issue Apr 7, 2016 · 5 comments
Closed

rename bitcoin.conf to zcash.conf #844

daira opened this issue Apr 7, 2016 · 5 comments
Assignees
@defuse
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. in 1.0 S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. usability Zcash codebase
Milestone
Protocol 2016.0-a...

Comments

@daira
Copy link
Contributor

daira commented Apr 7, 2016

No description provided.

@daira daira added Zcash codebase C-cleanup Category: PRs that clean code up or issues documenting cleanup. in 1.0 usability labels Apr 7, 2016
@daira daira added this to the Consensus Code Security Freeze milestone Apr 7, 2016
@JanKalin
Copy link

JanKalin commented Apr 8, 2016

There are other places where bitcoin remains, e.g., in the "zcash-cli" help message. But I'm sure that refactoring will be done before the final release.

@daira
Copy link
Contributor Author

daira commented Apr 8, 2016

Yes, I meant that we should prioritize this as more urgent than, e.g. changing message strings, to avoid people having to rename their bitcoin.conf files later (or worse, have their edits to them ignored).

@daira
Copy link
Contributor Author

daira commented Apr 19, 2016

Also rename bitcoind.pid to zcashd.pid.

https://github.com/nathan-at-least/zcash/blob/525a3b92238b9489effd5adc21a0b0d5de18269b/doc/files.md

@daira
Copy link
Contributor Author

daira commented May 2, 2016

I want to get this into the next release; the earlier we do it, the fewer people who have made changes to their config files will be affected.

@daira daira modified the milestones: Protocol 2.0-alpha-9bb4410 Implementation, Consensus Code Security Freeze May 2, 2016
@defuse defuse mentioned this issue May 2, 2016
Closed
@defuse defuse mentioned this issue May 3, 2016
Merged
@defuse defuse added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2016
@daira
Copy link
Contributor Author

daira commented May 4, 2016

Fixed via #907.

@daira daira closed this as completed May 4, 2016
str4d added a commit to str4d/zcash that referenced this issue Apr 21, 2023
@str4d
Squashed 'src/secp256k1/' changes from 1758a92ffd..be8d9c262f
7648f6b 
be8d9c262f Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM
aeece44599 gen_context: Don't use any ASM
7688a4f13a Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups
90e83449b2 ci: Add C++ test
f698caaff6 Use unsigned char consistently for byte arrays
b5b8e7b719 Don't declare constants twice
769528f307 Don't use string literals for char arrays without NUL termination
2cc3cfa583 Fix -Wmissing-braces warning in clang
0440945fb5 Merge zcash#844: schnorrsig API overhaul
ec3aaa5014 Merge zcash#960: tests_exhaustive: check the result of secp256k1_ecdsa_sign
a1ee83c654 tests_exhaustive: check the result of secp256k1_ecdsa_sign
253f90cdeb Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG
446d28d9de Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS
0302138f75 ci: Make compiler warning into errors on CI
b924e1e605 build: Ensure that configure's compile checks default to -O2
7939cd571c build: List *CPPFLAGS before *CFLAGS like on the compiler command line
595e8a35d8 build: Enable -Wcast-align=strict warning
07256267ff build: Use own variable SECP_CFLAGS instead of touching user CFLAGS
4866178dfc Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests
75ce488c2a Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse
41ed13942b tests: really test the non-var scalar inverse
5f6ceafcfa schnorrsig: allow setting MSGLEN != 32 in benchmark
fdd06b7967 schnorrsig: add tests for sign_custom and varlen msg verification
d8d806aaf3 schnorrsig: add extra parameter struct for sign_custom
a0c3fc177f schnorrsig: allow signing and verification of variable length msgs
5a8e4991ad Add secp256k1_tagged_sha256 as defined in BIP-340
b6c0b72fb0 schnorrsig: remove noncefp args from sign; add sign_custom function
bdf19f105c Add random field multiply/square tests
8ae56e33e7 Merge zcash#879: Avoid passing out-of-bound pointers to 0-size memcpy
a4642fa15e configure: replace AC_PATH_PROG to AC_CHECK_PROG
442cee5baf schnorrsig: add algolen argument to nonce_function_hardened
df3bfa12c3 schnorrsig: clarify result of calling nonce_function_bip340 without data
99e8614812 README: mention schnorrsig module
9570f674cc Avoid passing out-of-bound pointers to 0-size memcpy

git-subtree-dir: src/secp256k1
git-subtree-split: be8d9c262f46309d9b4165b0498b71d704aba8fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defuse defuse

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. in 1.0 S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. usability Zcash codebase
Projects
None yet
Milestone
Protocol 2016.0-alpha-3 Implementation
Development

No branches or pull requests
3 participants
@daira @defuse @JanKalin