Skip to content

Use in and or instead of multipleif's #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 17, 2025
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is doomed because data is not guaranteed to be hashable

@DimitriPapadopoulos
Copy link
Contributor Author

Perhaps I can keep the additional or though.

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PYL-R1714 branch 2 times, most recently from 08ac700 to a318d58 Compare July 17, 2025 21:34
@d-v-b
Copy link
Contributor

d-v-b commented Jul 17, 2025

what about using a tuple instead of a set?

@DimitriPapadopoulos DimitriPapadopoulos changed the title Consider using in Use or instead of multipleifs Jul 17, 2025
@DimitriPapadopoulos DimitriPapadopoulos changed the title Use or instead of multipleifs Use or instead of multipleif's Jul 17, 2025
@DimitriPapadopoulos
Copy link
Contributor Author

Of course, you're right.

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (df40f4f) to head (29f66e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3266   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files          78       78           
  Lines        8686     8684    -2     
=======================================
- Hits         5174     5173    -1     
+ Misses       3512     3511    -1     
Files with missing lines Coverage Δ
src/zarr/core/dtype/npy/common.py 61.53% <100.00%> (-0.73%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DimitriPapadopoulos DimitriPapadopoulos changed the title Use or instead of multipleif's Use in and or instead of multipleif's Jul 17, 2025
@d-v-b d-v-b enabled auto-merge (squash) July 17, 2025 22:11
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Jul 17, 2025
6 tasks
@d-v-b d-v-b merged commit bc5ca27 into zarr-developers:main Jul 17, 2025
30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PYL-R1714 branch July 17, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants