-
-
Notifications
You must be signed in to change notification settings - Fork 350
Use in
and or
instead of multipleif
's
#3266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is doomed because data
is not guaranteed to be hashable
Perhaps I can keep the additional |
08ac700
to
a318d58
Compare
what about using a tuple instead of a set? |
or
instead of multipleif
sor
instead of multipleif
's
Of course, you're right. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
=======================================
Coverage 59.56% 59.56%
=======================================
Files 78 78
Lines 8686 8684 -2
=======================================
- Hits 5174 5173 -1
+ Misses 3512 3511 -1
🚀 New features to boost your workflow:
|
a318d58
to
94f45e1
Compare
or
instead of multipleif
'sin
and or
instead of multipleif
's
TODO:
docs/user-guide/*.rst
changes/