-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indexing with bools #1968
Merged
normanrz
merged 23 commits into
zarr-developers:v3
from
scalableminds:fix-indexing-with-bools
Jun 28, 2024
Merged
Fix indexing with bools #1968
normanrz
merged 23 commits into
zarr-developers:v3
from
scalableminds:fix-indexing-with-bools
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38578dd.
jhamman
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick comments.
d-v-b
reviewed
Jun 23, 2024
d-v-b
reviewed
Jun 23, 2024
Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
# Conflicts: # src/zarr/indexing.py
normanrz
approved these changes
Jun 28, 2024
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Jul 25, 2024
* v3: (22 commits) chore: update pre-commit hooks (zarr-developers#2051) Apply ruff/flake8-bandit rule B006 (zarr-developers#2049) Move fixtures to `tests` (zarr-developers#1813) Multiple imports for an import name (zarr-developers#2047) Redundant list comprehension (zarr-developers#2048) chore: update pre-commit hooks (zarr-developers#2039) Cast fill value to array's dtype (zarr-developers#2020) chore: update pre-commit hooks (zarr-developers#2017) make shardingcodec pickleable (zarr-developers#2011) doc: copy 3.0.0.alpha changelog into release.rst (zarr-developers#2007) build(ci): enable python 3.12 in github actions (zarr-developers#2005) Bump NumPy to 2.0 (zarr-developers#1983) chore: update pre-commit hooks (zarr-developers#1989) Fix indexing with bools (zarr-developers#1968) Fix string interpolation (zarr-developers#1998) Unnecessary comprehension (zarr-developers#1997) Stop ignoring these ruff rules (zarr-developers#2001) Merge collapsible if statements (zarr-developers#1999) Unnecessary comprehension (zarr-developers#1996) Handle Path in `make_store_path` (zarr-developers#1992) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1963
Changes:
a[mask_selection]
a[bool_selection_axis1, bool_selection_axis2]
Example
For an Array
Each of the following failed before and works now