Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing ZipStore's __delitem__ via overwrite #828

Open
jakirkham opened this issue Sep 8, 2021 · 6 comments
Open

Implementing ZipStore's __delitem__ via overwrite #828

jakirkham opened this issue Sep 8, 2021 · 6 comments
Labels
good-first-issue Good place to get started as a new contributor.

Comments

@jakirkham
Copy link
Member

Currently ZipStore's __delitem__ raises NotImplementedError, which is a bit awkward to workaround at higher levels since __delitem__ is usually implemented in other stores. The reason this isn't implemented in ZipStore is zip files lack the ability to delete members.

An alternative approach that might be worth considering is overwriting the existing members with an empty string (b""). We can then treat them as deleted in Zarr.

@joshmoore joshmoore added the help wanted Issue could use help from someone with familiarity on the topic label Sep 22, 2021
@I-am-Emmanuel
Copy link

I'm an outreachy applicant, can I contribute to this project?

@jakirkham
Copy link
Member Author

Sure, please do Emmanuel 🙂

@jakirkham jakirkham added the good-first-issue Good place to get started as a new contributor. label Oct 13, 2022
@jakirkham
Copy link
Member Author

cc @MSanKeys963 @joshmoore (for awareness)

@KarlieKKY
Copy link

I'm an outreachy applicant, can I contribute to this project?

Hello, i'm also an outcheachy applicant, would you mind if we work on this issue together?

@jakirkham
Copy link
Member Author

Thanks for your interest! 😀

Emmanuel opened PR ( #1184 ) already.

Would suggest picking a different issue 🙂

@joshmoore joshmoore removed the help wanted Issue could use help from someone with familiarity on the topic label Nov 23, 2022
@jakirkham
Copy link
Member Author

Also worth noting there is an upstream issue about adding this functionality in CPython ( python/cpython#51067 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good place to get started as a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants