-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing ZipStore
's __delitem__
via overwrite
#828
Comments
I'm an outreachy applicant, can I contribute to this project? |
Sure, please do Emmanuel 🙂 |
cc @MSanKeys963 @joshmoore (for awareness) |
Hello, i'm also an outcheachy applicant, would you mind if we work on this issue together? |
Thanks for your interest! 😀 Emmanuel opened PR ( #1184 ) already. Would suggest picking a different issue 🙂 |
Also worth noting there is an upstream issue about adding this functionality in CPython ( python/cpython#51067 ) |
Currently
ZipStore
's__delitem__
raises
NotImplementedError
, which is a bit awkward to workaround at higher levels since__delitem__
is usually implemented in other stores. The reason this isn't implemented inZipStore
is zip files lack the ability to delete members.An alternative approach that might be worth considering is overwriting the existing members with an empty string (
b""
). We can then treat them as deleted in Zarr.The text was updated successfully, but these errors were encountered: