Skip to content

Commit e37713f

Browse files
Carreaujakirkham
andauthored
Remove 3.5 configuration from tox, run pyflakes on ghaction. (#641)
This will run way faster than travis and should allow to distinguish actual test failure from formatting failures in PRs if we deactivate flake8 from tox. Co-authored-by: jakirkham <jakirkham@gmail.com>
1 parent 23422fc commit e37713f

File tree

2 files changed

+26
-3
lines changed

2 files changed

+26
-3
lines changed

.github/workflows/releases.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,26 @@ jobs:
6767
user: __token__
6868
password: ${{ secrets.pypi_password }}
6969
# To test: repository_url: https://test.pypi.org/legacy/
70+
build_artifacts:
71+
name: Linting with flake8
72+
runs-on: ubuntu-latest
73+
strategy:
74+
fail-fast: false
75+
76+
steps:
77+
- uses: actions/checkout@v1
78+
with:
79+
submodules: true
80+
81+
- uses: actions/setup-python@v1
82+
name: Install Python
83+
with:
84+
python-version: '3.8'
85+
86+
- name: Install pyflakes
87+
run: |
88+
python -m pip install pyflakes
89+
- name: run pyflakes
90+
run: |
91+
pyflakes zarr
92+

tox.ini

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ commands =
1818
# clear out any data files generated during tests
1919
python -c 'import glob; import shutil; import os; [(shutil.rmtree(d) if os.path.isdir(d) else os.remove(d) if os.path.isfile(d) else None) for d in glob.glob("./example*")]'
2020
# main unit test runner
21-
py35,py36,py38: pytest -v --cov=zarr --cov-config=.coveragerc zarr
21+
py36,py38: pytest -v --cov=zarr --cov-config=.coveragerc zarr
2222
# don't collect coverage when running older numpy versions
2323
py37-{npy115,npy116}: pytest -v zarr
2424
# collect coverage and run doctests under py37
2525
py37-npylatest: pytest -v --cov=zarr --cov-config=.coveragerc --doctest-plus zarr --remote-data
2626
# generate a coverage report
27-
py35,py36,py37-npylatest,py38: coverage report -m
27+
py36,py37-npylatest,py38: coverage report -m
2828
# run doctests in the tutorial and spec
2929
py38: python -m doctest -o NORMALIZE_WHITESPACE -o ELLIPSIS docs/tutorial.rst docs/spec/v2.rst
3030
# pep8 checks
@@ -34,7 +34,7 @@ commands =
3434
deps =
3535
py37-npy115: numpy==1.15.4
3636
py37-npy116: numpy==1.16.4
37-
py35,py36,py37-npylatest,py38: -rrequirements_dev_numpy.txt
37+
py36,py37-npylatest,py38: -rrequirements_dev_numpy.txt
3838
-rrequirements_dev_minimal.txt
3939
-rrequirements_dev_optional.txt
4040

0 commit comments

Comments
 (0)