Enable some ruff rules (RUF) and fix issues (#1869)

* Enable some ruff rules (RUF)

* Apply ruff rule RUF010

RUF010 Use explicit conversion flag

* Apply ruff rule RUF019

RUF019 Unnecessary key check before dictionary access

* Apply ruff rule RUF100

RUF100 Unused `noqa` directive

Author: DimitriPapadopoulos

pyproject.toml

@@ -163,6 +163,18 @@ extend-exclude = [
     "docs"
 ]
 
+[tool.ruff.lint]
+extend-select = [
+    "RUF"
+]
+ignore = [
+    "RUF003",
+    "RUF005",
+    "RUF009",
+    "RUF012",
+    "RUF015",
+]
+
 [tool.mypy]
 python_version = "3.10"
 ignore_missing_imports = true

src/zarr/__init__.py

@@ -3,11 +3,11 @@
 from typing import Union
 
 import zarr.codecs  # noqa: F401
-from zarr.array import Array, AsyncArray  # noqa: F401
+from zarr.array import Array, AsyncArray
 from zarr.array_v2 import ArrayV2
 from zarr.config import config  # noqa: F401
-from zarr.group import AsyncGroup, Group  # noqa: F401
-from zarr.store import (  # noqa: F401
+from zarr.group import AsyncGroup, Group
+from zarr.store import (
     StoreLike,
     make_store_path,
 )

src/zarr/codecs/pipeline.py

@@ -93,7 +93,7 @@ def from_list(cls, codecs: List[Codec]) -> CodecPipeline:
             array_array_codecs=tuple(
                 codec for codec in codecs if isinstance(codec, ArrayArrayCodec)
             ),
-            array_bytes_codec=[codec for codec in codecs if isinstance(codec, ArrayBytesCodec)][0],
+            array_bytes_codec=next(codec for codec in codecs if isinstance(codec, ArrayBytesCodec)),
             bytes_bytes_codecs=tuple(
                 codec for codec in codecs if isinstance(codec, BytesBytesCodec)
             ),

src/zarr/common.py

@@ -81,7 +81,7 @@ def parse_enum(data: JSON, cls: Type[E]) -> E:
         raise TypeError(f"Expected str, got {type(data)}")
     if data in enum_names(cls):
         return cls(data)
-    raise ValueError(f"Value must be one of {repr(list(enum_names(cls)))}. Got {data} instead.")
+    raise ValueError(f"Value must be one of {list(enum_names(cls))!r}. Got {data} instead.")
 
 
 @dataclass(frozen=True)

src/zarr/store/core.py

@@ -48,7 +48,7 @@ def __str__(self) -> str:
         return _dereference_path(str(self.store), self.path)
 
     def __repr__(self) -> str:
-        return f"StorePath({self.store.__class__.__name__}, {repr(str(self))})"
+        return f"StorePath({self.store.__class__.__name__}, {str(self)!r})"
 
     def __eq__(self, other: Any) -> bool:
         try:

src/zarr/store/local.py

@@ -83,7 +83,7 @@ def __str__(self) -> str:
         return f"file://{self.root}"
 
     def __repr__(self) -> str:
-        return f"LocalStore({repr(str(self))})"
+        return f"LocalStore({str(self)!r})"
 
     def __eq__(self, other: object) -> bool:
         return isinstance(other, type(self)) and self.root == other.root

src/zarr/store/memory.py

@@ -23,7 +23,7 @@ def __str__(self) -> str:
         return f"memory://{id(self._store_dict)}"
 
     def __repr__(self) -> str:
-        return f"MemoryStore({repr(str(self))})"
+        return f"MemoryStore({str(self)!r})"
 
     async def get(
         self, key: str, byte_range: Optional[Tuple[int, Optional[int]]] = None

src/zarr/store/remote.py

@@ -39,7 +39,7 @@ def __str__(self) -> str:
         return str(self.root)
 
     def __repr__(self) -> str:
-        return f"RemoteStore({repr(str(self))})"
+        return f"RemoteStore({str(self)!r})"
 
     def _make_fs(self) -> Tuple[AsyncFileSystem, str]:
         import fsspec

src/zarr/sync.py

@@ -84,7 +84,7 @@ def sync(
     if len(unfinished) > 0:
         raise asyncio.TimeoutError(f"Coroutine {coro} failed to finish in within {timeout}s")
     assert len(finished) == 1
-    return_result = list(finished)[0].result()
+    return_result = next(iter(finished)).result()
 
     if isinstance(return_result, BaseException):
         raise return_result

src/zarr/v2/_storage/absstore.py

@@ -58,7 +58,7 @@ class ABSStore(Store):
     -----
     In order to use this store, you must install the Microsoft Azure Storage SDK for Python,
     ``azure-storage-blob>=12.5.0``.
-    """  # noqa: E501
+    """
 
     def __init__(
         self,

src/zarr/v2/meta.py

@@ -36,37 +36,37 @@
 def get_extended_dtype_info(dtype) -> dict:
     if dtype.str in _v3_complex_types:
         return dict(
-            extension="https://zarr-specs.readthedocs.io/en/core-protocol-v3.0-dev/protocol/extensions/complex-dtypes/v1.0.html",  # noqa
+            extension="https://zarr-specs.readthedocs.io/en/core-protocol-v3.0-dev/protocol/extensions/complex-dtypes/v1.0.html",
             type=dtype.str,
             fallback=None,
         )
     elif dtype.str == "|O":
         return dict(
-            extension="TODO: object array protocol URL",  # noqa
+            extension="TODO: object array protocol URL",
             type=dtype.str,
             fallback=None,
         )
     elif dtype.str.startswith("|S"):
         return dict(
-            extension="TODO: bytestring array protocol URL",  # noqa
+            extension="TODO: bytestring array protocol URL",
             type=dtype.str,
             fallback=None,
         )
     elif dtype.str.startswith("<U") or dtype.str.startswith(">U"):
         return dict(
-            extension="TODO: unicode array protocol URL",  # noqa
+            extension="TODO: unicode array protocol URL",
             type=dtype.str,
             fallback=None,
         )
     elif dtype.str.startswith("|V"):
         return dict(
-            extension="TODO: structured array protocol URL",  # noqa
+            extension="TODO: structured array protocol URL",
             type=dtype.descr,
             fallback=None,
         )
     elif dtype.str in _v3_datetime_types:
         return dict(
-            extension="https://zarr-specs.readthedocs.io/en/latest/extensions/data-types/datetime/v1.0.html",  # noqa
+            extension="https://zarr-specs.readthedocs.io/en/latest/extensions/data-types/datetime/v1.0.html",
             type=dtype.str,
             fallback=None,
         )

src/zarr/v2/n5.py

@@ -764,7 +764,7 @@ def compressor_config_to_zarr(compressor_config: Dict[str, Any]) -> Optional[Dic
         zarr_config["filters"] = None
 
     elif codec_id == "gzip":
-        if "useZlib" in compressor_config and compressor_config["useZlib"]:
+        if compressor_config.get("useZlib"):
             zarr_config["id"] = "zlib"
             zarr_config["level"] = compressor_config["level"]
         else:

src/zarr/v2/storage.py

@@ -631,7 +631,7 @@ def __len__(self):
         return len(self._mutable_mapping)
 
     def __repr__(self):
-        return f"<{self.__class__.__name__}: \n{repr(self._mutable_mapping)}\n at {hex(id(self))}>"
+        return f"<{self.__class__.__name__}: \n{self._mutable_mapping!r}\n at {hex(id(self))}>"
 
     def __eq__(self, other):
         if isinstance(other, KVStore):

tests/v2/test_storage_v3.py

@@ -65,7 +65,7 @@
 # from .test_storage import TestSQLiteStore as _TestSQLiteStore
 # from .test_storage import TestSQLiteStoreInMemory as _TestSQLiteStoreInMemory
 # from .test_storage import TestZipStore as _TestZipStore
-# from .test_storage import dimension_separator_fixture, s3, skip_if_nested_chunks  # noqa
+# from .test_storage import dimension_separator_fixture, s3, skip_if_nested_chunks
 
 
 # pytestmark = pytest.mark.skipif(not v3_api_available, reason="v3 api is not available")

tests/v2/test_sync.py

@@ -16,7 +16,7 @@
 from zarr.v2.sync import ProcessSynchronizer, ThreadSynchronizer
 
 # zarr_version fixture must be imported although not used directly here
-from .test_attrs import TestAttributes  # noqa
+from .test_attrs import TestAttributes
 from .test_core import TestArray
 from .test_hierarchy import TestGroup