Enable extra mypy error codes (#1909)

* Clean up v2 mypy ignores

* Enable extra mypy error codes

* Specific error code

---------

Co-authored-by: Joe Hamman <joe@earthmover.io>

Author: dstansby

pyproject.toml

@@ -190,6 +190,8 @@ namespace_packages = false
 strict = true
 
 
+enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
+
 [[tool.mypy.overrides]]
 module = [
     "zarr.v2.*",

src/zarr/buffer.py

@@ -79,7 +79,7 @@ def ravel(self, order: Literal["K", "A", "C", "F"] = "C") -> Self: ...
 
     def all(self) -> bool: ...
 
-    def __eq__(self, other: Any) -> Self:  # type: ignore
+    def __eq__(self, other: Any) -> Self:  # type: ignore[explicit-override, override]
         """Element-wise equal
 
         Notice

src/zarr/codecs/sharding.py

@@ -205,7 +205,7 @@ def merge_with_morton_order(
     ) -> _ShardBuilder:
         obj = cls.create_empty(chunks_per_shard)
         for chunk_coords in morton_order_iter(chunks_per_shard):
-            if tombstones is not None and chunk_coords in tombstones:
+            if chunk_coords in tombstones:
                 continue
             for shard_dict in shard_dicts:
                 maybe_value = shard_dict.get(chunk_coords, None)

src/zarr/indexing.py

@@ -199,11 +199,8 @@ def is_total_slice(item: Selection, shape: ChunkCoords) -> bool:
     if isinstance(item, tuple):
         return all(
             (
-                isinstance(dim_sel, slice)
-                and (
-                    (dim_sel == slice(None))
-                    or ((dim_sel.stop - dim_sel.start == dim_len) and (dim_sel.step in [1, None]))
-                )
+                (dim_sel == slice(None))
+                or ((dim_sel.stop - dim_sel.start == dim_len) and (dim_sel.step in [1, None]))
             )
             for dim_sel, dim_len in zip(item, shape, strict=False)
         )

src/zarr/metadata.py

@@ -432,10 +432,11 @@ def update_attributes(self, attributes: dict[str, JSON]) -> Self:
 def parse_dimension_names(data: None | Iterable[str]) -> tuple[str, ...] | None:
     if data is None:
         return data
-    if isinstance(data, Iterable) and all([isinstance(x, str) for x in data]):
+    elif all([isinstance(x, str) for x in data]):
         return tuple(data)
-    msg = f"Expected either None or a iterable of str, got {type(data)}"
-    raise TypeError(msg)
+    else:
+        msg = f"Expected either None or a iterable of str, got {type(data)}"
+        raise TypeError(msg)
 
 
 # todo: real validation

src/zarr/testing/store.py

@@ -47,7 +47,7 @@ def test_store_mode(self, store: S, store_kwargs: dict[str, Any]) -> None:
         assert store.writeable
 
         with pytest.raises(AttributeError):
-            store.mode = "w"  # type: ignore
+            store.mode = "w"  # type: ignore[misc]
 
         # read-only
         kwargs = {**store_kwargs, "mode": "r"}