Skip to content

Commit aa9a0d5

Browse files
Couple fixes (#1737)
* Use `is` when comparing `type` of two objects * Unnecessary `None` provided as default
1 parent 9864b40 commit aa9a0d5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

zarr/_storage/store.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ def inner_store(self) -> Union["StorageTransformer", StoreV3]:
462462

463463
def __eq__(self, other):
464464
return (
465-
type(self) == type(other)
465+
type(self) is type(other)
466466
and self._inner_store == other._inner_store
467467
and self.get_config() == other.get_config()
468468
)

zarr/tests/test_core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def create_array(self, shape: Union[int, Tuple[int, ...]], **kwargs):
123123
"compressor": kwargs.pop("compressor", self.compressor),
124124
"chunk_store": chunk_store,
125125
"storage_transformers": self.create_storage_transformers(shape),
126-
"filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype", None))),
126+
"filters": kwargs.pop("filters", self.create_filters(kwargs.get("dtype"))),
127127
}
128128

129129
# keyword arguments for array instantiation

0 commit comments

Comments
 (0)