Skip to content

Commit 5af9d5f

Browse files
committed
Add None to indent test parameters
1 parent 37f96b0 commit 5af9d5f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/test_metadata/test_v3.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ def test_metadata_to_dict(
305305
assert observed == expected
306306

307307

308-
@pytest.mark.parametrize('indent', (2, 4))
308+
@pytest.mark.parametrize('indent', (2, 4, None))
309309
def test_json_indent(indent: int):
310310
with config.set({"json_indent": indent}):
311311
m = GroupMetadata()
@@ -315,9 +315,13 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
315315
super().__init__(*args, **kwargs)
316316
self.indent = indent
317317

318-
# expected has extra ' ' on each line compared with json.dumps( indent=2)
318+
# using json.JSONEncoder adds an extra ' ' on each line
319+
# compared with json.dumps(json.loads(d), indent=2)...
319320
expected = json.dumps(json.loads(d), cls=TestIndentEncoder).encode()
320321
assert d == expected
322+
# ...but we can check that None really removes indent.
323+
if indent is None:
324+
assert d == json.dumps(json.loads(d), indent=indent).encode()
321325

322326

323327
# @pytest.mark.parametrize("fill_value", [-1, 0, 1, 2932897])

0 commit comments

Comments
 (0)