Disallow untyped defs

Author: dstansby

pyproject.toml

@@ -169,6 +169,8 @@ disallow_any_generics = true
 
 disallow_incomplete_defs = true
 
+disallow_untyped_defs = true
+
 [[tool.mypy.overrides]]
 module = [
     "zarr.v2._storage.store",
@@ -207,6 +209,17 @@ module = [
 ]
 disallow_incomplete_defs = false
 
+[[tool.mypy.overrides]]
+module = [
+    "zarr.v2.*",
+    "zarr.array_v2",
+    "zarr.array",
+    "zarr.common",
+    "zarr.group",
+    "zarr.metadata"
+]
+disallow_untyped_defs = false
+
 [tool.pytest.ini_options]
 doctest_optionflags = [
     "NORMALIZE_WHITESPACE",

src/zarr/array.py

@@ -21,6 +21,7 @@
 
 # from zarr.array_v2 import ArrayV2
 from zarr.codecs import BytesCodec
+from zarr.codecs.pipeline import CodecPipeline
 from zarr.common import (
     ZARR_JSON,
     ArraySpec,
@@ -55,7 +56,7 @@ class AsyncArray:
     runtime_configuration: RuntimeConfiguration
 
     @property
-    def codecs(self):
+    def codecs(self) -> CodecPipeline:
         return self.metadata.codecs
 
     def __init__(
@@ -402,7 +403,7 @@ async def update_attributes(self, new_attributes: Dict[str, Any]) -> AsyncArray:
         await (self.store_path / ZARR_JSON).set(new_metadata.to_bytes())
         return replace(self, metadata=new_metadata)
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         return f"<AsyncArray {self.store_path} shape={self.shape} dtype={self.dtype}>"
 
     async def info(self):
@@ -542,7 +543,7 @@ def update_attributes(self, new_attributes: Dict[str, Any]) -> Array:
             )
         )
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         return f"<Array {self.store_path} shape={self.shape} dtype={self.dtype}>"
 
     def info(self):

src/zarr/attributes.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 from collections.abc import MutableMapping
-from typing import TYPE_CHECKING, Any, Union
+from typing import TYPE_CHECKING, Any, Iterator, Union
 
 if TYPE_CHECKING:
     from zarr.group import Group
@@ -12,21 +12,21 @@ def __init__(self, obj: Union[Array, Group]):
         # key=".zattrs", read_only=False, cache=True, synchronizer=None
         self._obj = obj
 
-    def __getitem__(self, key):
+    def __getitem__(self, key: str) -> Any:
         return self._obj.metadata.attributes[key]
 
-    def __setitem__(self, key, value):
+    def __setitem__(self, key: str, value: Any) -> None:
         new_attrs = dict(self._obj.metadata.attributes)
         new_attrs[key] = value
         self._obj = self._obj.update_attributes(new_attrs)
 
-    def __delitem__(self, key):
+    def __delitem__(self, key: str) -> None:
         new_attrs = dict(self._obj.metadata.attributes)
         del new_attrs[key]
         self._obj = self._obj.update_attributes(new_attrs)
 
-    def __iter__(self):
+    def __iter__(self) -> Iterator[str]:
         return iter(self._obj.metadata.attributes)
 
-    def __len__(self):
+    def __len__(self) -> int:
         return len(self._obj.metadata.attributes)

src/zarr/indexing.py

@@ -19,7 +19,7 @@ def _err_too_many_indices(selection: SliceSelection, shape: ChunkCoords) -> None
     )
 
 
-def _err_negative_step():
+def _err_negative_step() -> None:
     raise IndexError("only slices with step >= 1 are supported")
 
 
@@ -50,7 +50,7 @@ class _ChunkDimProjection(NamedTuple):
     dim_out_sel: Optional[slice]
 
 
-def _ceildiv(a, b):
+def _ceildiv(a: float, b: float) -> int:
     return math.ceil(a / b)