Skip to content

Commit 3fce479

Browse files
committed
Filter s3 rather than ABS
1 parent 43e6aaf commit 3fce479

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/python-package.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,14 @@ jobs:
7575
run: |
7676
# Skip ABS on 3.9, see https://github.com/zarr-developers/zarr-python/pull/1542/#issuecomment-1945557365 etc.
7777
if [[ "${{ matrix.python-version }}" == '3.9' ]]; then
78-
echo "ZARR_TEST_ABS=0" >> "$GITHUB_ENV"
78+
FILTER='-k "not test_s3"'
7979
else
80-
echo "ZARR_TEST_ABS=1" >> "$GITHUB_ENV"
80+
FILTER=''
8181
fi
8282
conda activate zarr-env
8383
mkdir ~/blob_emulator
8484
azurite -l ~/blob_emulator --debug debug.log 2>&1 > stdouterr.log &
85-
pytest --cov=zarr --cov-config=pyproject.toml --doctest-plus --cov-report xml --cov=./ --timeout=300
85+
pytest --cov=zarr --cov-config=pyproject.toml --doctest-plus --cov-report xml --cov=./ --timeout=300 ${FILTER}
8686
- uses: codecov/codecov-action@v3
8787
with:
8888
token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos

.github/workflows/windows-testing.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ jobs:
4747
run: |
4848
# Skip ABS on 3.9, see https://github.com/zarr-developers/zarr-python/pull/1542/#issuecomment-1945557365 etc.
4949
if [[ "${{ matrix.python-version }}" == '3.9' ]]; then
50-
echo "ZARR_TEST_ABS=0" >> "$GITHUB_ENV"
50+
FILTER='-k "not test_s3"'
5151
else
52-
echo "ZARR_TEST_ABS=1" >> "$GITHUB_ENV"
52+
FILTER=''
5353
fi
5454
conda activate zarr-env
5555
mkdir ~/blob_emulator
5656
azurite -l ~/blob_emulator --debug debug.log 2>&1 > stdouterr.log &
57-
pytest -sv --timeout=300
57+
pytest -sv --timeout=300 ${FILTER}
5858
env:
5959
ZARR_V3_EXPERIMENTAL_API: 1
6060
ZARR_V3_SHARDING: 1

0 commit comments

Comments
 (0)