We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The get_codec function modifies its argument, popping the "id" key. This can lead to surprising behaviour such as:
get_codec
config = {"id": "json"} codec = get_codec(config) # Works codec = get_codec(config) # fails.
I suggest adding config = dict(config) at the start of the function. The performance implications should be minimal I think.
config = dict(config)
The text was updated successfully, but these errors were encountered:
SGTM, although I think there may be some other code that relies on the "id" having been popped. May need some adjustment. PR welcome.
Sorry, something went wrong.
9be5d94
Ensures that get_codec doesn't modify its argument.
88bf001
Closes zarr-developers#78.
No branches or pull requests
The
get_codec
function modifies its argument, popping the "id" key. This can lead to surprising behaviour such as:I suggest adding
config = dict(config)
at the start of the function. The performance implications should be minimal I think.The text was updated successfully, but these errors were encountered: