-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening via xarray backendentrypoint #35
Comments
This would be cool, but it's actually not needed for an MVP, because we have |
Trying to get this to work leads down rabbit holes like the one in pydata/xarray#8712 |
Note that to get the syntax |
I'm no longer so sure that we actually need this feature? It's a bit of a pain to implement because it likely requires finicky upstream changes to xarray, and the benefit in the end is purely syntactic sugar, not actually new capability. It's also weird design-wise for a few reasons:
I'm curious what others think, especially @ayushnag, @betolink, and @sharkinsspatial. |
Some changes are needed in xarray to support using the xarray backend entrypoint system to open datasets from disk as
ManifestArray
-backed Variables just by passing a keyword arg toopen_dataset
/open_mfdataset
. This requires dodging some internal array wrapping that occurs in the depths of xarray's backend machinery.Originally posted by @TomNicholas in #14 (comment)
The text was updated successfully, but these errors were encountered: