Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the --timeout flag to time the entire deployment rather than a single helm install / upgrade #2962

Open
AustinAbro321 opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement ✨ New feature or request ga Issues tracking toward Zarf 1.0
Milestone

Comments

@AustinAbro321
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently the timeout flag on zarf package deploy is used only for helm. A deployment fails if any of the helm installs or upgrades take longer than the given timeout or the default timeout of 15 minutes. We plan to extend the timeout flag in #2678 to for use in health checks on components.

This behavior may be confusing for users, theoretically the command zarf package deploy --timeout 15m can last for hours depending on how many helm installs take place. It may be better for the timeout to simply fail when the zarf package deploy takes longer than the submitted timeout. Ideally this change would occur during the v1 release where breaking changes will be more expected.

We must consider if there should be a default value in this case. A Zarf package can be complex and take hours to deploy without anything going wrong. Large image pushes, for example, can take a long time depending on the network of the environment.

@AustinAbro321 AustinAbro321 added enhancement ✨ New feature or request breaking-change 💔 ga Issues tracking toward Zarf 1.0 labels Sep 3, 2024
@salaxander salaxander added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request ga Issues tracking toward Zarf 1.0
Projects
Status: Backlog
Development

No branches or pull requests

3 participants