Skip to content

Commit eed1625

Browse files
musicakcjanaszewski
authored andcommitted
leds: da903x: Use devm_led_classdev_register
Switch to resource-managed function devm_led_classdev_register instead of led_classdev_register and remove unneeded led_classdev_unregister. Also, remove platform_set_drvdata in probe function and the remove function, da903x_led_remove as it is now has nothing to do. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @platform@ identifier p, probefn, removefn; @@ struct platform_driver p = { .probe = probefn, .remove = removefn, }; @prb@ identifier platform.probefn, pdev; expression e; @@ probefn(struct platform_device *pdev, ...) { ... e = - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } //</smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
1 parent 48a7032 commit eed1625

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

drivers/leds/leds-da903x.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -113,21 +113,12 @@ static int da903x_led_probe(struct platform_device *pdev)
113113
led->flags = pdata->flags;
114114
led->master = pdev->dev.parent;
115115

116-
ret = led_classdev_register(led->master, &led->cdev);
116+
ret = devm_led_classdev_register(led->master, &led->cdev);
117117
if (ret) {
118118
dev_err(&pdev->dev, "failed to register LED %d\n", id);
119119
return ret;
120120
}
121121

122-
platform_set_drvdata(pdev, led);
123-
return 0;
124-
}
125-
126-
static int da903x_led_remove(struct platform_device *pdev)
127-
{
128-
struct da903x_led *led = platform_get_drvdata(pdev);
129-
130-
led_classdev_unregister(&led->cdev);
131122
return 0;
132123
}
133124

@@ -136,7 +127,6 @@ static struct platform_driver da903x_led_driver = {
136127
.name = "da903x-led",
137128
},
138129
.probe = da903x_led_probe,
139-
.remove = da903x_led_remove,
140130
};
141131

142132
module_platform_driver(da903x_led_driver);

0 commit comments

Comments
 (0)