tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe

Yuuoniy · gregkh · commit bcea0f547ec1 · 2022-04-15T11:08:12.000+02:00
Fix the missing clk_disable_unprepare() before return from owl_uart_probe() in the error handling case. Fixes: abf42d2 ("tty: serial: owl: add "much needed" clk_prepare_enable()") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220307105135.11698-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c
@@ -731,6 +731,7 @@ static int owl_uart_probe(struct platform_device *pdev)
 	owl_port->port.uartclk = clk_get_rate(owl_port->clk);
 	if (owl_port->port.uartclk == 0) {
 		dev_err(&pdev->dev, "clock rate is zero\n");
+		clk_disable_unprepare(owl_port->clk);
 		return -EINVAL;
 	}
 	owl_port->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP | UPF_LOW_LATENCY;

Original file line number	Diff line number	Diff line change
`@@ -731,6 +731,7 @@ static int owl_uart_probe(struct platform_device *pdev)`
`731`	`731`	`owl_port->port.uartclk = clk_get_rate(owl_port->clk);`
`732`	`732`	`if (owl_port->port.uartclk == 0) {`
`733`	`733`	`dev_err(&pdev->dev, "clock rate is zero\n");`
	`734`	`+ clk_disable_unprepare(owl_port->clk);`
`734`	`735`	`return -EINVAL;`
`735`	`736`	`}`
`736`	`737`	`owl_port->port.flags = UPF_BOOT_AUTOCONF \| UPF_IOREMAP \| UPF_LOW_LATENCY;`