ipmi_si: Fix wrong return value in try_smi_init()

uudiin · cminyard · commit 8fe7990ceda8 · 2020-10-05T13:30:51.000-05:00
On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 90b2d4f ("ipmi_si: Remove hacks for adding a dummy platform devices") Cc: Corey Minyard <cminyard@mvista.com> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> Message-Id: <20201005145212.84435-1-tianjia.zhang@linux.alibaba.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1980,7 +1980,7 @@ static int try_smi_init(struct smi_info *new_smi)
 	/* Do this early so it's available for logs. */
 	if (!new_smi->io.dev) {
 		pr_err("IPMI interface added with no device\n");
-		rv = EIO;
+		rv = -EIO;
 		goto out_err;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1980,7 +1980,7 @@ static int try_smi_init(struct smi_info *new_smi)`
`1980`	`1980`	`/* Do this early so it's available for logs. */`
`1981`	`1981`	`if (!new_smi->io.dev) {`
`1982`	`1982`	`pr_err("IPMI interface added with no device\n");`
`1983`		`- rv = EIO;`
	`1983`	`+ rv = -EIO;`
`1984`	`1984`	`goto out_err;`
`1985`	`1985`	`}`
`1986`	`1986`