Skip to content

Commit 7974ecd

Browse files
lcolittifelipebalbi
authored andcommitted
usb: gadget: f_ncm: allow using NCM in SuperSpeed Plus gadgets.
Currently, enabling f_ncm at SuperSpeed Plus speeds results in an oops in config_ep_by_speed because ncm_set_alt passes in NULL ssp_descriptors. Fix this by re-using the SuperSpeed descriptors. This is safe because usb_assign_descriptors calls usb_copy_descriptors. Tested: enabled f_ncm on a dwc3 gadget and 10Gbps link, ran iperf Reviewed-by: Maciej Żenczykowski <maze@google.com> Signed-off-by: Lorenzo Colitti <lorenzo@google.com> Signed-off-by: Felipe Balbi <balbi@kernel.org>
1 parent a176b1a commit 7974ecd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/usb/gadget/function/f_ncm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1536,7 +1536,7 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f)
15361536
fs_ncm_notify_desc.bEndpointAddress;
15371537

15381538
status = usb_assign_descriptors(f, ncm_fs_function, ncm_hs_function,
1539-
ncm_ss_function, NULL);
1539+
ncm_ss_function, ncm_ss_function);
15401540
if (status)
15411541
goto fail;
15421542

0 commit comments

Comments
 (0)