Skip to content

Commit 4cf7bc0

Browse files
mawilli1Jeff Kirsher
authored andcommitted
ice: don't spam VFs with link messages
Don't send a link message to the VFs unless link actually changes state. This avoids a small timing hole in some VF drivers that can cause an apparent TX hang if they receive a link status message at the wrong time. Although we have fixed the timing hole in the current VF driver, there are still lots of drivers in the field that have this timing hole. Let's not fall into it if we can avoid it. Signed-off-by: Mitch Williams <mitch.a.williams@intel.com> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
1 parent b751930 commit 4cf7bc0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/intel/ice/ice_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,8 @@ ice_link_event(struct ice_pf *pf, struct ice_port_info *pi)
609609
}
610610
}
611611

612-
ice_vc_notify_link_state(pf);
612+
if (!new_link_same_as_old && pf->num_alloc_vfs)
613+
ice_vc_notify_link_state(pf);
613614

614615
return 0;
615616
}

0 commit comments

Comments
 (0)