Skip to content

Commit 346497c

Browse files
magnus-karlssonanguy11
authored andcommitted
i40e: optimize for XDP_REDIRECT in xsk path
Optimize i40e_run_xdp_zc() for the XDP program verdict being XDP_REDIRECT in the xsk zero-copy path. This path is only used when having AF_XDP zero-copy on and in that case most packets will be directed to user space. This provides a little over 100k extra packets in throughput on my server when running l2fwd in xdpsock. Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent 2117fce commit 346497c

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

drivers/net/ethernet/intel/i40e/i40e_xsk.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,17 +160,20 @@ static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
160160
xdp_prog = READ_ONCE(rx_ring->xdp_prog);
161161
act = bpf_prog_run_xdp(xdp_prog, xdp);
162162

163+
if (likely(act == XDP_REDIRECT)) {
164+
err = xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
165+
result = !err ? I40E_XDP_REDIR : I40E_XDP_CONSUMED;
166+
rcu_read_unlock();
167+
return result;
168+
}
169+
163170
switch (act) {
164171
case XDP_PASS:
165172
break;
166173
case XDP_TX:
167174
xdp_ring = rx_ring->vsi->xdp_rings[rx_ring->queue_index];
168175
result = i40e_xmit_xdp_tx_ring(xdp, xdp_ring);
169176
break;
170-
case XDP_REDIRECT:
171-
err = xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
172-
result = !err ? I40E_XDP_REDIR : I40E_XDP_CONSUMED;
173-
break;
174177
default:
175178
bpf_warn_invalid_xdp_action(act);
176179
fallthrough;

0 commit comments

Comments
 (0)