Skip to content

Commit 1d41698

Browse files
Tang Bingregkh
authored andcommitted
usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe()
If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in exynos_ohci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Fixes: 6219424 ("USB: Add Samsung Exynos OHCI diver") Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20200826144931.1828-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent bfd08d0 commit 1d41698

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/usb/host/ohci-exynos.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,8 @@ static int exynos_ohci_probe(struct platform_device *pdev)
171171
hcd->rsrc_len = resource_size(res);
172172

173173
irq = platform_get_irq(pdev, 0);
174-
if (!irq) {
175-
dev_err(&pdev->dev, "Failed to get IRQ\n");
176-
err = -ENODEV;
174+
if (irq < 0) {
175+
err = irq;
177176
goto fail_io;
178177
}
179178

0 commit comments

Comments
 (0)