Skip to content

Commit 08ee77b

Browse files
AxelLinThierry Reding
authored andcommitted
pwm: lpc32xx: Properly set PWM_ENABLE bit in lpc32xx_pwm_[enable|disable]
According to the LPC32x0 User Manual [1]: For both PWM1 and PWM2 Control Registers: BIT 31: This bit gates the PWM_CLK signal and enables the external output pin to the PWM_PIN_STATE logical level. 0 = PWM disabled. (Default) 1 = PWM enabled So in lpc32xx_pwm_enable(), we should set PWM_ENABLE bit. In lpc32xx_pwm_disable(), we should just clear PWM_ENABLE bit rather than write 0 to the register which will also clear PWMx_RELOADV and PWMx_DUTY bits. [1] http://www.nxp.com/documents/user_manual/UM10326.pdf Signed-off-by: Axel Lin <axel.lin@ingics.com> Tested-by: Roland Stigge <stigge@antcom.de> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
1 parent f1a8870 commit 08ee77b

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

drivers/pwm/pwm-lpc32xx.c

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,29 @@ static int lpc32xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
7777
static int lpc32xx_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
7878
{
7979
struct lpc32xx_pwm_chip *lpc32xx = to_lpc32xx_pwm_chip(chip);
80+
u32 val;
81+
int ret;
82+
83+
ret = clk_enable(lpc32xx->clk);
84+
if (ret)
85+
return ret;
8086

81-
return clk_enable(lpc32xx->clk);
87+
val = readl(lpc32xx->base + (pwm->hwpwm << 2));
88+
val |= PWM_ENABLE;
89+
writel(val, lpc32xx->base + (pwm->hwpwm << 2));
90+
91+
return 0;
8292
}
8393

8494
static void lpc32xx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
8595
{
8696
struct lpc32xx_pwm_chip *lpc32xx = to_lpc32xx_pwm_chip(chip);
97+
u32 val;
98+
99+
val = readl(lpc32xx->base + (pwm->hwpwm << 2));
100+
val &= ~PWM_ENABLE;
101+
writel(val, lpc32xx->base + (pwm->hwpwm << 2));
87102

88-
writel(0, lpc32xx->base + (pwm->hwpwm << 2));
89103
clk_disable(lpc32xx->clk);
90104
}
91105

0 commit comments

Comments
 (0)