Skip to content

Added beautiful option for json #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexkrnet
Copy link

This PR adds an option to JSONWriter class for beautiful (intended) json output.

@goofballLogic
Copy link
Contributor

Rather than developing a long list of flags for the method, might be nice to have a non static version of the class which can be configured?
Con: Although it might mean that the (valuable) cut'n'paste option would be harder.
Pro: It would also allow for dependency injection.

@JD-Howard
Copy link

This PR adds an option to JSONWriter class for beautiful (intended) json output.

I know this is old, but just wanted to say thank you.

This was the a perfectly isolated addition that just works. It would be more optimal for it to be fully integrated, but such a beautiful thing when a major feature is entirely cut/paste like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants