Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test (wal-g) backup compression algorithms are supported #1007

Open
macedigital opened this issue Jul 23, 2024 · 0 comments
Open

Test (wal-g) backup compression algorithms are supported #1007

macedigital opened this issue Jul 23, 2024 · 0 comments

Comments

@macedigital
Copy link
Member

Why?

Wal-g 3.x made brotli compression an optional build flag, see wal-g/wal-g#1379. Upgrading to v3.x broke assumptions in some clusters relying on brotli compression and explicitly setting backup creation to use wal-g. Restoration would have equally failed, but in those cases no backups could be created in the first place.

Proposed solution

  • The proposed fix is to use pre-built wal-g binaries from the source repository itself instead of compiling in Spilo, which at this moment seem to include brotli compression (Install wal-g from a precompiled bin #1006)

To prevent any regressions, we should run automated tests to verify that all expected compression algorithms are still working for each Spilo build as expressed in this comment #1006 (comment), because lz4 or lzma might be dropped (or made optional) at one time in future as well.

This would help detecting issues with creating or restoring from backups early.

for algo in lz4 lzma brotli; do
  # ... verify backups can be created and restored from $algo
done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant