Skip to content

use uint64 for replication lag from Patroni's member endpoint #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2022
Merged

use uint64 for replication lag from Patroni's member endpoint #1893

merged 3 commits into from
May 19, 2022

Conversation

@FxKu
Copy link
Member

@FxKu FxKu commented May 16, 2022 •
edited
Loading

fixes #1890

using a custom uint64 type with its own UnmarshalJSON method

@FxKu FxKu added this to the 1.8.1 milestone May 16, 2022
@idanovinda
Copy link
Member

idanovinda commented May 18, 2022

👍

@FxKu
Copy link
Member Author

FxKu commented May 18, 2022

👍

1 similar comment
@jopadi
Copy link
Member

jopadi commented May 19, 2022

👍

@FxKu FxKu merged commit 97be5ee into master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idanovinda idanovinda idanovinda approved these changes

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.8.1

Development

Successfully merging this pull request may close these issues.

Lag (ClusterMember.members.lag) value over int32 max value

4 participants

@FxKu @idanovinda @jopadi