fix helm's postgres-operator/values.yaml #1480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the data types in values.yaml are "wrong". if you just perform an "helm
install" then the installation fails with a LOT of error messages about
wrong data types.
for example configGeneral.enable_crd_validation is '"true"' (i.e. a string
value) in the values.yaml file, but should be just 'true' (a yaml
boolean value).
weirdly, #configPostgresPodResources.default_cpu_limit is expected to be
string although a numerical value (wrong as well?), just like
configConnectionPooler.connection_pooler_default_cpu_limit.
this commit fixes it. AFTER applying you can just do this:
helm upgrade -i pg-operator zalando/pg-operator
TESTED WITH 1.6.2.
see also:
- https://git.io/J3z4S
flypenguin
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
erthalion and
sdudoladov
as code owners
Member
Author
|
oh look two identical PRs. maybe it's a flawed situation breaking expectations of all people using helm 😆 thanks for the quick reply though, that's indeed rare. |
Member
|
Closing, since we merged #1224 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the data types in values.yaml are "wrong". if you just perform an "helm install" then the installation fails with a LOT of error messages about wrong data types.
for example configGeneral.enable_crd_validation is '"true"' (i.e. a string value) in the values.yaml file, but should be just 'true' (a yaml boolean value).
weirdly, configPostgresPodResources.default_cpu_limit is expected to be string although a numerical value (wrong as well?), just like configConnectionPooler.connection_pooler_default_cpu_limit.
this commit fixes it. AFTER applying you can just do this:
TESTED WITH 1.6.2.
see also: