-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve e2e tests #1111
Merged
Merged
Improve e2e tests #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdudoladov
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M and
RafiaSabih
as code owners
August 18, 2020 11:05
👍 |
👎 The change to go modules made e2e tests independent from OS. I would prefer to keep that. Maybe some users out there are arleady relying on it. I understand that |
…t be the right solution though.
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up tests:
Fix the issue with the test runner sometimes failing to fetch the
registry.opensource.zalan.do/acid/postgres-operator-e2e-tests:latest
.Description of the fix :
${operator_tag}
was not found locally.-dirty
suffix added y git inVERSION ?= $(shell git describe --tags --always --dirty)
kind
viago get
. That from time to time modifiesgo.mod
andgo.sum
and in that way pollutes the working dir.run.sh
computes the image tag again, but this time the tag gets the-dirty
suffix. So we actually haveimage-name
locally, but try to fetchimage-name-dirty
, which obviuosly fails and the pull command from above is triggerd, and that fails as well. Installingkind
manually removes the issue.