Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-chart: allow configmaps instead of endpoints for leader elections… #1037

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

Gottox
Copy link
Contributor

@Gottox Gottox commented Jun 29, 2020

This fixes leader election in 1.5 on Openshift.

@Gottox
Copy link
Contributor Author

Gottox commented Jun 30, 2020

Any idea what's wrong with the tests? I can't see how my change has triggered the issue.

@ReSearchITEng
Copy link
Contributor

ReSearchITEng commented Jul 3, 2020

Can we get a similar condition also for operator roles? There should be no need even for get endpoints.

# to manage endpoints which are also used by Patroni

@Gottox
Copy link
Contributor Author

Gottox commented Jul 3, 2020

@ReSearchITEng applied!

@FxKu
Copy link
Member

FxKu commented Jul 10, 2020

@Gottox can you change the operator cluster role in the same way? Because the operator can also create a binding between the postgres-pod clusterrole and pod service account, but IIRC requires to have at least the same privileges for this. So if the pod role has a section for endpoints and the operator role lacks it, this operation would fail, I think.

@Gottox
Copy link
Contributor Author

Gottox commented Jul 24, 2020

I'm currently on vacations, will do it on monday! 😄

@FxKu
Copy link
Member

FxKu commented Sep 24, 2020

@Gottox any chance you can have a look at this PR again and update the cluster role? Thanks!

@FxKu FxKu added this to the 1.6 milestone Dec 16, 2020
@Jan-M
Copy link
Member

Jan-M commented Dec 16, 2020

👍

1 similar comment
@FxKu
Copy link
Member

FxKu commented Dec 16, 2020

👍

@FxKu FxKu merged commit 4b90809 into zalando:master Dec 16, 2020
@FxKu
Copy link
Member

FxKu commented Dec 16, 2020

Thanks @Gottox for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants