Merge pull request quarkusio#45593 from Sola-ris/client-builder-copy-config

Copy `Configuration` when building a JAX-RS `Client`

Author: geoand

independent-projects/resteasy-reactive/client/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/ClientBuilderImpl.java

@@ -286,7 +286,7 @@ public ClientImpl build() {
 
         options.setMaxChunkSize(maxChunkSize);
         return new ClientImpl(options,
-                configuration,
+                new ConfigurationImpl(configuration),
                 CLIENT_CONTEXT_RESOLVER.resolve(Thread.currentThread().getContextClassLoader()),
                 null,
                 null,

independent-projects/resteasy-reactive/client/runtime/src/test/java/org/jboss/resteasy/reactive/client/impl/ClientBuilderTest.java

@@ -0,0 +1,46 @@
+package org.jboss.resteasy.reactive.client.impl;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotSame;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+import java.io.IOException;
+
+import jakarta.ws.rs.client.Client;
+import jakarta.ws.rs.client.ClientBuilder;
+import jakarta.ws.rs.client.ClientRequestContext;
+import jakarta.ws.rs.client.ClientRequestFilter;
+import jakarta.ws.rs.core.Response;
+
+import org.junit.jupiter.api.Test;
+
+public class ClientBuilderTest {
+
+    @Test
+    void configurationCopiedOnBuild() {
+        ClientBuilder builder = ClientBuilder.newBuilder();
+
+        Client firstClient = builder.build();
+        firstClient.property("foo", "bar");
+        firstClient.register(Always500.class);
+
+        Client secondClient = builder.build();
+
+        try (firstClient; secondClient) {
+            // Should not be the same instance
+            assertNotSame(firstClient.getConfiguration(), secondClient.getConfiguration());
+
+            // Should not be affected by changes to firstClient's Configuration
+            assertNull(secondClient.getConfiguration().getProperty("foo"));
+            assertFalse(secondClient.getConfiguration().getClasses().contains(Always500.class));
+        }
+    }
+
+    public static class Always500 implements ClientRequestFilter {
+
+        @Override
+        public void filter(ClientRequestContext requestContext) throws IOException {
+            requestContext.abortWith(Response.serverError().build());
+        }
+    }
+}