Implement numeric placeholders

Author: zacharymarshal

src/NamedSqlParams.php

@@ -21,6 +21,10 @@ class NamedSqlParams
      * @var array
      */
     private $quoted_tokens;
+    /**
+     * @var bool
+     */
+    private $numeric_placeholders;
 
     /**
      * @param array $options
@@ -30,11 +34,13 @@ public function __construct(array $options = [])
         $quoted_tokens = [':', false];
         $unquoted_tokens = [':!', false];
         $debug_fn = [$this, 'debug'];
+        $numeric_placeholders = false;
         extract($options, EXTR_IF_EXISTS);
 
         $this->quoted_tokens = $quoted_tokens;
         $this->unquoted_tokens = $unquoted_tokens;
         $this->debug_fn = $debug_fn;
+        $this->numeric_placeholders = $numeric_placeholders;
     }
 
     /**
@@ -47,9 +53,10 @@ public function prep($sql, array $params = [], array $options = [])
     {
         $debug = (!empty($options['debug']) ? $options['debug'] : false);
         $prepared_params = [];
+        $placeholder_index = 0;
         $prepared_sql = preg_replace_callback(
             $this->getTokenRegex(),
-            function ($matches) use ($params, &$prepared_params, $debug) {
+            function ($matches) use ($params, &$prepared_params, &$placeholder_index, $debug) {
                 $quote_string = $matches[1];
                 $param = $matches[2];
 
@@ -78,9 +85,12 @@ function ($matches) use ($params, &$prepared_params, $debug) {
                         );
                     } else {
                         $prepared_params[] = $one_value;
-                        $placeholders[] = '?';
+                        if ($this->numeric_placeholders) {
+                            $placeholders[] = '$' . ++$placeholder_index;
+                        } else {
+                            $placeholders[] = '?';
+                        }
                     }
-
                 }
 
                 return implode(', ', $placeholders);

tests/testNamedSqlParams.php

@@ -71,3 +71,45 @@ function(Test $test) {
         $test->equals($params, ['1'], 'should return 1 parameter');
     }
 );
+
+Test::create(
+    "numeric placeholders",
+    function(Test $test) {
+        $named = new NamedSqlParams(['numeric_placeholders' => true]);
+        list($p_sql, $p_params) = $named->prep(
+            "SELECT 1 FROM whatever WHERE one = :one AND two = :two",
+            ['one' => 1, 'two' => 2]
+        );
+        $test->equals(
+            $p_params,
+            [1, 2],
+            "should return array of prepped params"
+        );
+        $test->equals(
+            $p_sql,
+            "SELECT 1 FROM whatever WHERE one = $1 AND two = $2",
+            "should return sql with numeric placeholders"
+        );
+    }
+);
+
+Test::create(
+    "numeric array values",
+    function(Test $test) {
+        $named = new NamedSqlParams(['numeric_placeholders' => true]);
+        list($p_sql, $p_params) = $named->prep(
+            "SELECT 1 FROM whatever WHERE id IN (:ids) AND id2 IN (:ids2)",
+            ['ids' => [1, 2], 'ids2' => [3, 4]]
+        );
+        $test->equals(
+            $p_params,
+            [1, 2, 3, 4],
+            "should return single array for all values"
+        );
+        $test->equals(
+            $p_sql,
+            "SELECT 1 FROM whatever WHERE id IN ($1, $2) AND id2 IN ($3, $4)",
+            "should return sql with numeric placeholders"
+        );
+    }
+);