Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pre-commit for Markdown All in One #1403

Open
gnawin opened this issue Mar 12, 2024 · 2 comments
Open

Enable pre-commit for Markdown All in One #1403

gnawin opened this issue Mar 12, 2024 · 2 comments
Labels
Help wanted Looking for help. Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks.

Comments

@gnawin
Copy link

gnawin commented Mar 12, 2024

Proposal

To run Markdown All in One as part of a pre-commit workflow, and provide relevant information to the repos list in the project's .pre-commit-config.yaml.

Other information

My user case is automatic formatting of tables. Adding Markdown All in One as part of the workflow will ensure a consistent style.

@yzhang-gh
Copy link
Owner

yzhang-gh commented Mar 23, 2024

Thanks for your suggestion. It looks similar as #1394 which is about the TOC.

The difference is that GFM table formating should already be done by other packages, e.g. Prettier?

@yzhang-gh yzhang-gh added Help wanted Looking for help. Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks. labels Mar 23, 2024
@gnawin
Copy link
Author

gnawin commented Mar 25, 2024

Thank you. We've changed to Prettier. If there were a pre-commit hook for Markdown All in One, we would have chose it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Looking for help. Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks.
Projects
None yet
Development

No branches or pull requests

2 participants