Breaks Tab key, ignoring VSCode settings and inserting spaces instead

[brandonkal]

Problem

When this extension is enabled, the tab key inserts two spaces instead of how the VSCode editor is configured.

How to reproduce

1. Configure VSCode to use tabs for indentation and set tab size to 4. Make whitespace visible to see the issue.
2. Open a markdown file with tab-indented nested bullet lists
3. Hit the tab key in front of a line of text to increase the indent of that line (or use the VSCode shortcut cmd+])
4. Observe that two spaces are used in place of the tab character

Disabling this extension eliminates the issue so this extension is likely doing something funky.

Configuration

Default

Environment

Name: Markdown All in One
Id: yzhang.markdown-all-in-one
Description: All you need to write Markdown (keyboard shortcuts, table of contents, auto preview and more)
Version: 3.4.3
Publisher: Yu Zhang
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=yzhang.markdown-all-in-one

VSCode About
Version: 1.68.1
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
Date: 2022-06-14T12:52:13.188Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 19.6.0

[yzhang-gh]

Did you check the tab size at the right bottom corner? In Markdown files it is often automatically set to 2. The tab key should work as expected if you have the tab size configured as 4.

[knutov]

It's really broken.

Step to reproduce:

1. create new file
2. set tab size to 4, select use tabs, select markdown as format
3. type something
4. select some string, use tab or ctrl+]

It will be indented with 3 spaces :(

[yzhang-gh]

The Tab may not work 100% as I expect (e.g. for multiline selection). However, the tab configuration is respected on my machine.

[knutov]

Did test again, and it's always 3 spcaces with this extension installed. Even if I set use tabs and tab size = 8.

From extension list with query "@installed markdown" only this extension installed.

With this extension disabled tab size works as expected.

Version: 1.69.0 (user setup)
Commit: 92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9
Date: 2022-07-07T05:28:36.503Z (3 days ago)
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.19044

Could some other extension conflict with this?

[knutov]

more tests: Extensions - Disable all installed - reload.

only remote ssh from microsoft enabled and this one, and the problem exists.

[knutov]

More details: If I select only one line the problem occures. But if I select 2+ lines - all works with tabs as expected. And usually problem happens only with lists, not with paragraphs.

Also, for unnumbered lists it is two spaces, while for numbered - three spaces.

[yzhang-gh]

Alright, I get the point from your last GIF. By default, the "indentation" inside a Markdown list is changed to "adaptive" mode. That's why you get 3 spaces right after an ordered list and 2 for an unordered list.

Please change markdown.extension.list.indentationSize to inherit and you will always get the configured tab size. (cc @brandonkal)