Merge pull request #12 from yuuki/fix_connect_nil_pointer_dereference

yuuki · web-flow · commit 6afc370ab320 · 2021-05-24T13:59:53.000+09:00
connect: fix nil pointer dereference of the 'conn' object
diff --git a/cmd/connect.go b/cmd/connect.go
@@ -296,6 +296,7 @@ func connectPersistent(ctx context.Context, addrport string) error {
 				if err != nil {
 					cause <- xerrors.Errorf("could not dial %q: %w", addrport, err)
 					cancel()
+					return
 				}
 				defer conn.Close()
 

Original file line number	Diff line number	Diff line change
`@@ -296,6 +296,7 @@ func connectPersistent(ctx context.Context, addrport string) error {`
`296`	`296`	`if err != nil {`
`297`	`297`	`cause <- xerrors.Errorf("could not dial %q: %w", addrport, err)`
`298`	`298`	`cancel()`
	`299`	`+ return`
`299`	`300`	`}`
`300`	`301`	`defer conn.Close()`
`301`	`302`