Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YCQL] Check correctness of picking read time for non transactional operations before conflict resolution #19498

Open
1 task done
pkj415 opened this issue Oct 12, 2023 · 0 comments
Assignees
Labels
area/ycql Yugabyte CQL (YCQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@pkj415
Copy link
Contributor

pkj415 commented Oct 12, 2023

Jira Link: DB-8295

Description

As seen in #19407, read time should not be picked until conflict resolution is successful for the non-transactional
operation path. This is because ResolveOperationConflicts() doesn't check regular db for
conflicting data committed in regular db. If in future, we have to read data before conflict
resolution, we should check conflicts in regular db too.

Once #19407 is fixed, YSQL ensures that all single-shard operations avoid picking a read time in the query layer. YCQL still picks read times in the query layer for non-transatcional operations. We should check if similar correctness issues can occur in YCQL, and if so, avoid picking a read time on the YCQL query layer. Once this is done, enable the RSTATUS_DCHECK(!read_time_, IllegalState,, ....) in WriteQuery::DoExecute() that has been commented out with this gh issue number.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@pkj415 pkj415 added area/ycql Yugabyte CQL (YCQL) status/awaiting-triage Issue awaiting triage labels Oct 12, 2023
@pkj415 pkj415 self-assigned this Oct 12, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ycql Yugabyte CQL (YCQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants