[jsinterp] Overhaul JSInterp to handle new YT players 4c3f79c5, 324f67b9 #31170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
* back-port from yt-dlp 8f53dc4, thanks pukkandan * also support void, improve <</>> precedence, improve expressions in comma-list * add more tests
dirkf
force-pushed
the
dlp-jsinterp-ovrhaul
branch
from
31421df
to
6bfc29e
Compare
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Aug 14, 2022
* https://github.com/ytdl-org/youtube-dl: [jsinterp] Overhaul JSInterp to handle new YT players 4c3f79c5, 324f67b9 (ytdl-org#31170)
pukkandan
reviewed
Aug 15, 2022
Comment on lines
+364
to
+369
| if len(sub_expressions) > 1: | ||
| for sub_expr in sub_expressions: | ||
| ret, should_abort = self.interpret_statement(sub_expr, local_vars, allow_recursion) | ||
| if should_abort: | ||
| return ret, True | ||
| return ret, False |
There was a problem hiding this comment.
Could you explain to me the reasoning behind this change? All your tests pass in yt-dlp without this
There was a problem hiding this comment.
...the last item of a multi-item list wasn't fully processed
Before: process list, pop last item, continue processing last item instead of list or processing last item from the beginning (where's the goto when you need it!).
Comment on lines
+659
to
+663
| @classmethod | ||
| def build_arglist(cls, arg_text): | ||
| if not arg_text: | ||
| return [] | ||
| return list(filter(None, (x.strip() or None for x in cls._separate(arg_text)))) |
There was a problem hiding this comment.
Same. The filter doesn't make sense to me
There was a problem hiding this comment.
Removing empty items, but there shouldn't be any:
function fred(a,b,c) {
return b;
}
fred(1, ,2);
/*
Exception: SyntaxError: expected expression, got ','
@Scratchpad/1:4
*/
function fred(a,,c) {
return c;
}
/*
Exception: SyntaxError: missing formal parameter
@Scratchpad/1:1
*/So probably just strip and let it crash elsewhere.
gaming-hacker
added a commit
to gaming-hacker/youtube-dl
that referenced
this pull request
Aug 16, 2022
* commit 'e52e8b8111cf7ca27daef184bacd926865e951b1': [postprocessor] Don't replace existing value with null metadata parsed from title [jsinterp] Overhaul JSInterp to handle new YT players 4c3f79c5, 324f67b9 (ytdl-org#31170) [core] Make `--max-downloads ...` stop immediately on reaching the limit [test, etc] Improve download test logs; also clean up some new flake8 issues (ytdl-org#31153) [aenetworks] Update _THEPLATFORM_KEY and _THEPLATFORM_SECRET (ytdl-org#29749) # Conflicts: # test/test_utils.py # youtube_dl/jsinterp.py
belamenso
pushed a commit
to belamenso/youtube-dl
that referenced
this pull request
Sep 19, 2022
…7b9 (ytdl-org#31170) * back-port from yt-dlp 8f53dc4, thanks pukkandan * also support void, improve <</>> precedence, improve expressions in comma-list * add more tests
gaming-hacker
added a commit
to gaming-hacker/youtube-dl
that referenced
this pull request
Oct 6, 2022
* commit 'b6bfdb25f200ba63ba1b011a54431cb424be46e9': (23 commits) [jsinterp] Workaround operator associativity issue * temporary fix for player 5a3b6271 [1] [cache] Add cache validation by program version, based on yt-dlp [jsinterp] Handle new YT players 113ca41c, c57c113c * add NaN * allow any white-space character for `after_op` * align with yt-dlp f26af78 (charcodeAt and bitwise overflow) * allow escaping in regex, fixing player c57c113c [options] Document that postprocessing is not forced by --postprocessor-args [compat] Replace deficient ChainMap class in Py3.3 and earlier * fix version check [compat] Replace deficient ChainMap class in Py3.3 and earlier [jsinterp] Improve try/catch/finally support [jsinterp] Fix bug in operator precedence * from yt-dlp/yt-dlp@164b03c * added tests [YouTube] Improve error check for n-sig processing [core] Avoid processing empty format list after removing bad formats * also ensure compat encoding of error strings [utils] Ensure RFC3986 encoding result is unicode [infoq] Avoid crash if the page has no `mp3Form` [uktvplay] Support domain without .uktv [jsinterp] Clean up and pull yt-dlp style * add compat_re_Pattern * improve compat_collections_chain_map * use class JS_Undefined * remove unused code [jsinterp] Handle regexp literals and throw/catch execution (ytdl-org#31182) [jsinterp] Improve JS language support (ytdl-org#31175) [postprocessor] Don't replace existing value with null metadata parsed from title [jsinterp] Overhaul JSInterp to handle new YT players 4c3f79c5, 324f67b9 (ytdl-org#31170) [core] Make `--max-downloads ...` stop immediately on reaching the limit [test, etc] Improve download test logs; also clean up some new flake8 issues (ytdl-org#31153) ...
alxlive
pushed a commit
to alxlive/youtube-dl
that referenced
this pull request
Feb 27, 2023
…7b9 (ytdl-org#31170) * back-port from yt-dlp 8f53dc4, thanks pukkandan * also support void, improve <</>> precedence, improve expressions in comma-list * add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boilerplate: mixed code, bug fix
## Please follow the guide belowxinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Issue #31164 reported errors with new players served by YouTube. More complex JS constructs confused yt-dl's JSInterp mini-JS interpreter.
Thanks mostly to @pukkandan, this PR fixes the problem code by back-porting from pukkandan/yt-dlp-dev@8f53dc4 into the existing previously back-ported framework.
Additionally:
voidused in player 324f67b9<</>>precedence (TODO item in back-ported code), by preventing an operator search for</>from matching the operator with the same first characterlet,constin case they should appearnew Date(...)