From 30178722b4f6f19d98740aeda1922aff3b64b75b Mon Sep 17 00:00:00 2001 From: Olivier Maisonneuve Date: Fri, 14 Mar 2014 14:33:03 +0100 Subject: [PATCH] Minor code review. --- Paybox/System/Base/Request.php | 2 +- Paybox/System/Base/Response.php | 6 +++--- Paybox/System/Cancellation/Request.php | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Paybox/System/Base/Request.php b/Paybox/System/Base/Request.php index f37ff37..b66d88c 100644 --- a/Paybox/System/Base/Request.php +++ b/Paybox/System/Base/Request.php @@ -102,7 +102,7 @@ public function getParameters() { if (null === $this->getParameter('PBX_HMAC')) { $this->setParameter('PBX_TIME', date('c')); - $this->setParameter('PBX_HMAC', strtoupper(parent::computeHmac())); + $this->setParameter('PBX_HMAC', strtoupper($this->computeHmac())); } $resolver = new ParameterResolver($this->globals['currencies']); diff --git a/Paybox/System/Base/Response.php b/Paybox/System/Base/Response.php index 6e21063..ef694f4 100644 --- a/Paybox/System/Base/Response.php +++ b/Paybox/System/Base/Response.php @@ -45,9 +45,9 @@ class Response /** * Contructor. * - * @param HttpRequest $request - * @param LoggerInterface $logger - * @param EventDispatcher $dispatcher + * @param HttpRequest $request + * @param LoggerInterface $logger + * @param EventDispatcherInterface $dispatcher */ public function __construct(HttpRequest $request, LoggerInterface $logger, EventDispatcherInterface $dispatcher) { diff --git a/Paybox/System/Cancellation/Request.php b/Paybox/System/Cancellation/Request.php index cb4d9c0..23c6510 100644 --- a/Paybox/System/Cancellation/Request.php +++ b/Paybox/System/Cancellation/Request.php @@ -24,9 +24,9 @@ class Request extends Paybox /** * Constructor. * - * @param array $parameters - * @param array $servers - * @param FormFactoryInterface $factory + * @param array $parameters + * @param array $servers + * @param TransportInterface $transport */ public function __construct(array $parameters, array $servers, TransportInterface $transport = null) { @@ -55,7 +55,7 @@ public function getParameters() { if (null === $this->getParameter('HMAC')) { $this->setParameter('TIME', date('c')); - $this->setParameter('HMAC', strtoupper(parent::computeHmac())); + $this->setParameter('HMAC', strtoupper($this->computeHmac())); } $resolver = new ParameterResolver();