-
-
Notifications
You must be signed in to change notification settings - Fork 414
chore: add winget install instruction to readme and website #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lazysegtree
merged 3 commits into
yorukot:main
from
claykom:feat/add-winget-install-instructions
Jul 26, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claykom Can you please add a example output in the PR, as a proof that it works, in case someone later has issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just drop the output in PR comments. For us to keep as a reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, does winget supports uninstall ?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lazysegtree Yes it does out of the box kinda, it will remove the bin and path variable I believe but for a better uninstall I think you can package it into the release files and provide one in the manifest. I'm looking into this because I'm not sure if winget-releaser action can add an uninstall script.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lazysegtree This will uninstall it by removing the executable, and remove it from your path; however it will not remove the config folder. We cannot add a powershell uninstall script, but there is other options.
I think if we want to keep this simple and use winget-releaser we may have to make a dedicated MSI/EXE installer/uninstaller for Windows. It's the right way to do it it anyway, the way we currently are doing it isn't right, we should be adding it to the registry so it's detected as a program.
This also brings out some other issues in our CI pipeline, we eventually should build out an action to build a release on push of new tag.
Install
❯ winget install --id yorukot.superfile
Found superfile [yorukot.superfile] Version v1.3.3
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Successfully verified installer hash
Extracting archive...
Successfully extracted archive
Starting package install...
Path environment variable modified; restart your shell to use the new value.
Command line alias added: "spf"
Successfully installed
Uninstall
❯ winget uninstall superfile
Found superfile [yorukot.superfile]
Starting package uninstall...
Successfully uninstalled
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misunderstood since it's not a real installer it may only work for me since I have the files already; needs more testing. Does scoop use the release files or the install.ps1?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it does work to install, I tested on a new machine that had never had it installed before. But I don't think we can guarantee it install/uninstalls the way we want it too without an installer.
You can decide if you want to wait until we have a proper installer to include these instructions.