Merge pull request #879 from yorukot/disable_nerdfont

enhance: add detailed documentation for InitIcon function and update …

Author: yorukot

src/config/icon/function.go

@@ -1,10 +1,29 @@
 package icon
 
+// InitIcon initializes the icon configuration for the application.
+// It sets up different icons based on whether nerd fonts are enabled and configures directory icon colors.
+//
+// Parameters:
+//   - nerdfont: boolean flag to determine if nerd fonts should be used
+//     When false, uses simple ASCII characters for icons
+//     When true, uses nerd font icons (default behavior)
+//   - directoryIconColor: string representing the color for directory icons
+//     If empty, defaults to "NONE" (dark yellowish)
+//
+// The function configures various icons for:
+//   - System directories (Home, Download, Documents, etc.)
+//   - File operations (Compress, Extract, Copy, Cut, Delete)
+//   - UI elements (Cursor, Browser, Select, etc.)
+//   - Status indicators (Error, Warn, Done, InOperation)
+//   - Navigation and sorting (Directory, Search, SortAsc, SortDesc)
 func InitIcon(nerdfont bool, directoryIconColor string) {
 	// Make sure that these alternatives are ASCII characters only.
 	// Dont place any special unicode characters here.
 	if !nerdfont {
-		// Do we need this to be empty ? Maybe it should just be normal space ?
+		// When nerdfont is disabled, we use simple ASCII characters
+		// Space is set to empty string because we don't need special spacing
+		// for ASCII characters, unlike nerd fonts which often need proper spacing
+		// to display correctly
 		Space = ""
 		SuperfileIcon = ""
 
@@ -36,6 +55,7 @@ func InitIcon(nerdfont bool, directoryIconColor string) {
 		Search = ""
 		SortAsc = "^"
 		SortDesc = "v"
+		Terminal = ""
 		Pinned = ""
 		Disk = ""
 	}

src/internal/ui/prompt/model.go

@@ -18,16 +18,9 @@ func DefaultModel(maxHeight int, width int) Model {
 		common.Hotkeys.OpenCommandLine[0], common.Config.ShellCloseOnSuccess, maxHeight, width)
 }
 
-func getHeadLine() string {
-	if common.Config.Nerdfont {
-		return icon.Terminal + " "
-	}
-	return ""
-}
-
 func GenerateModel(spfPromptHotkey string, shellPromptHotkey string, closeOnSuccess bool, maxHeight int, width int) Model {
 	m := Model{
-		headline:          getHeadLine() + promptHeadlineText,
+		headline:          icon.Terminal + icon.Space + promptHeadlineText,
 		open:              false,
 		shellMode:         true,
 		textInput:         common.GeneratePromptTextInput(),