fix: PR comments: Add unit tests for icon_utils

Author: lazysegtree

src/internal/common/icon_utils.go

@@ -7,11 +7,11 @@ import (
 	"github.com/yorukot/superfile/src/config/icon"
 )
 
-func GetElementIcon(file string, isDir bool) icon.Style {
+func GetElementIcon(file string, isDir bool, nerdFont bool) icon.Style {
 	ext := strings.TrimPrefix(filepath.Ext(file), ".")
 	name := file
 
-	if !Config.Nerdfont {
+	if !nerdFont {
 		return icon.Style{
 			Icon:  "",
 			Color: Theme.FilePanelFG,

src/internal/common/icon_utils_test.go

@@ -0,0 +1,83 @@
+package common
+
+import (
+	"testing"
+
+	"github.com/yorukot/superfile/src/config/icon"
+)
+
+func TestGetElementIcon(t *testing.T) {
+	tests := []struct {
+		name     string
+		file     string
+		isDir    bool
+		nerdFont bool
+		expected icon.Style
+	}{
+		{
+			name:     "Non-nerdfont returns empty icon",
+			file:     "test.txt",
+			isDir:    false,
+			nerdFont: false,
+			expected: icon.Style{
+				Icon:  "",
+				Color: Theme.FilePanelFG,
+			},
+		},
+		{
+			name:     "Directory with nerd font",
+			file:     "folder",
+			isDir:    true,
+			nerdFont: true,
+			expected: icon.Folders["folder"],
+		},
+		{
+			name:     "File with known extension",
+			file:     "test.go",
+			isDir:    false,
+			nerdFont: true,
+			expected: icon.Icons["go"],
+		},
+		{
+			name:     ".git directory",
+			file:     ".git",
+			isDir:    true,
+			nerdFont: true,
+			expected: icon.Folders[".git"],
+		},
+		{
+			name:     "superfile directory",
+			file:     "superfile",
+			isDir:    true,
+			nerdFont: true,
+			expected: icon.Folders["superfile"],
+		},
+		{
+			name:     "package.json file",
+			file:     "package.json",
+			isDir:    false,
+			nerdFont: true,
+			expected: icon.Icons["package"],
+		},
+		{
+			name:     "File with unknown extension",
+			file:     "test.xyz",
+			isDir:    false,
+			nerdFont: true,
+			expected: icon.Style{
+				Icon: icon.Icons["file"].Icon,
+				// Theme is not defined here, so this will be blank
+				Color: Theme.FilePanelFG,
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := GetElementIcon(tt.file, tt.isDir, tt.nerdFont)
+			if result.Icon != tt.expected.Icon || result.Color != tt.expected.Color {
+				t.Errorf("GetElementIcon() = %v, want %v", result, tt.expected)
+			}
+		})
+	}
+}

src/internal/common/string_function.go

@@ -58,7 +58,7 @@ func TruncateMiddleText(text string, maxChars int, talis string) string {
 }
 
 func PrettierName(name string, width int, isDir bool, isSelected bool, bgColor lipgloss.Color) string {
-	style := GetElementIcon(name, isDir)
+	style := GetElementIcon(name, isDir, Config.Nerdfont)
 	if isSelected {
 		return StringColorRender(lipgloss.Color(style.Color), bgColor).
 			Background(bgColor).
@@ -73,15 +73,15 @@ func PrettierName(name string, width int, isDir bool, isSelected bool, bgColor l
 }
 
 func PrettierDirectoryPreviewName(name string, isDir bool, bgColor lipgloss.Color) string {
-	style := GetElementIcon(name, isDir)
+	style := GetElementIcon(name, isDir, Config.Nerdfont)
 	return StringColorRender(lipgloss.Color(style.Color), bgColor).
 		Background(bgColor).
 		Render(style.Icon+" ") +
 		FilePanelStyle.Render(name)
 }
 
 func ClipboardPrettierName(name string, width int, isDir bool, isSelected bool) string {
-	style := GetElementIcon(name, isDir)
+	style := GetElementIcon(name, isDir, Config.Nerdfont)
 	if isSelected {
 		return StringColorRender(lipgloss.Color(style.Color), FooterBGColor).
 			Background(FooterBGColor).