You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Possible conflict with OreExcavation and therefore not Tainted Magic's fault.
Steps to reproduce:
Reduce Disassembler to low charge
Vein Mine a large group of blocks using a mod such as OreExcavation
Entropic Charge is subtracted correctly, OreExcavation bypasses digspeed check.
Therefore, we end up with a negative entropic charge value.
Disassembler now works infinitely with no speed loss.
I think I've found the line that causes this issue: Line 86 in ItemThaumicDisassembler.java: return getEntropyCharge(stack) != 0 ? getEfficiency(stack) : 1f;
where != 0 is used instead of > 0. Changing this line wouldn't prevent the value from going below 0, but would stop the disassembler from functioning at full speed infinitely when it does happen.
Using latest release 8.1.0 with the latest version of Thaumcraft 4. Using OreExcavation version 1.1.134.
The text was updated successfully, but these errors were encountered:
Possible conflict with OreExcavation and therefore not Tainted Magic's fault.
Steps to reproduce:
I think I've found the line that causes this issue: Line 86 in ItemThaumicDisassembler.java:
return getEntropyCharge(stack) != 0 ? getEfficiency(stack) : 1f;
where
!= 0
is used instead of> 0
. Changing this line wouldn't prevent the value from going below 0, but would stop the disassembler from functioning at full speed infinitely when it does happen.Using latest release 8.1.0 with the latest version of Thaumcraft 4. Using OreExcavation version 1.1.134.
The text was updated successfully, but these errors were encountered: