Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thaumic Disassembler running on negative entropy charge #80

Open
penguin-glitch opened this issue Jul 21, 2022 · 1 comment
Open

Thaumic Disassembler running on negative entropy charge #80

penguin-glitch opened this issue Jul 21, 2022 · 1 comment
Labels

Comments

@penguin-glitch
Copy link

Possible conflict with OreExcavation and therefore not Tainted Magic's fault.

Steps to reproduce:

  1. Reduce Disassembler to low charge
  2. Vein Mine a large group of blocks using a mod such as OreExcavation
  3. Entropic Charge is subtracted correctly, OreExcavation bypasses digspeed check.
  4. Therefore, we end up with a negative entropic charge value.
  5. Disassembler now works infinitely with no speed loss.

I think I've found the line that causes this issue: Line 86 in ItemThaumicDisassembler.java:
return getEntropyCharge(stack) != 0 ? getEfficiency(stack) : 1f;
where != 0 is used instead of > 0. Changing this line wouldn't prevent the value from going below 0, but would stop the disassembler from functioning at full speed infinitely when it does happen.

Using latest release 8.1.0 with the latest version of Thaumcraft 4. Using OreExcavation version 1.1.134.

@penguin-glitch
Copy link
Author

penguin-glitch commented Jul 22, 2022

Just had the disassembler go down to negative charge even when I wasn't vein mining, so it's not an OreExcavation issue

@yorkeJohn yorkeJohn added the bug label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants