Skip to content

Commit 4bd369f

Browse files
committed
Revert "[s3] add support for testing on macOS (tensorflow#1253)"
This reverts commit 81789bd. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
1 parent 3e16038 commit 4bd369f

File tree

3 files changed

+7
-20
lines changed

3 files changed

+7
-20
lines changed

tests/test_aws/aws_test.sh

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
set -e
1818
set -o pipefail
1919

20-
export LOCALSTACK_VERSION=0.12.2
21-
cd tests/test_aws
22-
TMPDIR=/private$TMPDIR docker-compose up -d
23-
cd -
24-
echo "Waiting for 20 secs until localstack is up and running"
25-
sleep 20
20+
LOCALSTACK_VERSION=0.12.2
21+
docker pull localstack/localstack:$LOCALSTACK_VERSION
22+
docker run -d --rm --net=host --name=tensorflow-io-aws localstack/localstack:$LOCALSTACK_VERSION
23+
echo "Waiting for 10 secs until localstack is up and running"
24+
sleep 10
2625
echo "Localstack up"
2726
exit 0

tests/test_aws/docker-compose.yml

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/test_s3_eager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424

2525

2626
@pytest.mark.skipif(
27-
sys.platform in ("win32"),
28-
reason="TODO Localstack not setup properly on Windows yet",
27+
sys.platform in ("win32", "darwin"),
28+
reason="TODO Localstack not setup properly on macOS/Windows yet",
2929
)
3030
def test_read_file():
3131
"""Test case for reading S3"""

0 commit comments

Comments
 (0)