Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy only when installing" for "Embed App Extensions" #948

Merged
merged 16 commits into from
Oct 2, 2020
Merged

"Copy only when installing" for "Embed App Extensions" #948

merged 16 commits into from
Oct 2, 2020

Conversation

RomanPodymov
Copy link
Contributor

@RomanPodymov RomanPodymov commented Sep 10, 2020

Hello.
Thank you for XcodeGen.
In this pull request I fixed #947. Added onlyCopyExtensionsOnInstall and using it the same way as onlyCopyFilesOnInstall from #912 but for app extensions.
Also, I think onlyCopyFilesOnInstall should be renamed to onlyCopyFrameworksOnInstall.

@RomanPodymov RomanPodymov marked this pull request as draft September 10, 2020 20:28
@RomanPodymov RomanPodymov reopened this Sep 11, 2020
@RomanPodymov RomanPodymov marked this pull request as ready for review September 11, 2020 08:15
@yonaskolb
Copy link
Owner

Thanks for this @RomanPodymov. Would there be cases where onlyCopyExtensionsOnInstall would be a different value to onlyCopyFilesOnInstall? Otherwise we could just use the same property

@RomanPodymov
Copy link
Contributor Author

RomanPodymov commented Sep 14, 2020

Hello @yonaskolb
Well, I have a project where I should have selected Embed App Extensions / Copy only when installing and unselected Embed Frameworks / Copy only when installing.
That's why I think that onlyCopyFilesOnInstall is not a good name for this property, it should be something like onlyCopyFrameworksOnInstall.
@zjkuang What do you think?

@RomanPodymov
Copy link
Contributor Author

Hello @yonaskolb
It works for me if I select both Embed App Extensions / Copy only when installing and Embed Frameworks / Copy only when installing. If you want I can use onlyCopyFilesOnInstall for all Copy only when installing checkboxes.

@yonaskolb
Copy link
Owner

yonaskolb commented Sep 30, 2020

@RomanPodymov I think sticking with onlyCopyFilesOnInstall that controls all the copying is good for now. If down the line people need more discrete options we can look at adding onlyCopyFrameworksOnInstall and onlyCopyExtensionsOnInstall, but I don't think they should be necessary

@RomanPodymov
Copy link
Contributor Author

Hello @yonaskolb
Now onlyCopyFilesOnInstall is using for all phases where possible.

@yonaskolb yonaskolb merged commit 742fe69 into yonaskolb:master Oct 2, 2020
@tkachenkovv
Copy link

@yonaskolb
Hello.
Thank you for XcodeGen.
We REALLY need separate checkboxes for "Embed App Extensions" and "Embed Frameworks"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Copy only when installing" for "Embed App Extensions" (NOT "Embed Frameworks") in "Build Phases"
3 participants