Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugEnabled option for run and test #657

Merged
merged 6 commits into from
Sep 22, 2019

Conversation

kateinoigakukun
Copy link
Collaborator

When we use some libraries like johnno1962/Fortify, we need to disable debugger.
So I added the option which enables us to disable it explicitly.

@yonaskolb
Copy link
Owner

I tested this by editing a scheme in Xcode and noticed that when deselecting debug executable that the selectedLauncherIdentifier also changed from Xcode.DebuggerFoundation.Launcher.LLDB to Xcode.IDEFoundation.Launcher.PosixSpawn

@@ -687,6 +687,7 @@ The different actions share some properties:
- [ ] **disableMainThreadChecker**: **Bool** - `run` and `test` actions can define a boolean that indicates that this scheme should disable the Main Thread Checker. This defaults to false
- [ ] **language**: **String** - `run` and `test` actions can define a language that is used for Application Language
- [ ] **region**: **String** - `run` and `test` actions can define a language that is used for Application Region
- [ ] **debugEnabled**: **Bool** - `run` and `test` actions can define a whether debugger should be used.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add This defaults to true and then we can merge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@yonaskolb yonaskolb merged commit 78d2152 into yonaskolb:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants