Adds new Title Screens from Contest 2024 (#21574)

* Initial

* Optimise

* File Normalisation

* Adds jokes always on April Fools

* More changes

* Reduce Size

* Update

* Update

* Update code/controllers/subsystem/title.dm

Co-authored-by: TheGamerdk <5618080+TheGamerdk@users.noreply.github.com>

* Update code/controllers/subsystem/title.dm

* Last changes

---------

Co-authored-by: TheGamerdk <5618080+TheGamerdk@users.noreply.github.com>

Author: JamieD1

code/controllers/subsystem/title.dm

@@ -19,17 +19,33 @@ SUBSYSTEM_DEF(title)
 			previous_icon = new(previous_icon)
 	fdel("data/previous_title.dat")
 
-	var/list/provisional_title_screens = flist("[global.config.directory]/title_screens/images/")
+	var/list/normal_provisional_title_screens = flist("[global.config.directory]/title_screens/images/normal/")
+	var/list/joke_provisional_title_screens = flist("[global.config.directory]/title_screens/images/joke/")
+	var/list/rare_provisional_title_screens = flist("[global.config.directory]/title_screens/images/rare/")
 	var/list/title_screens = list()
-	var/use_rare_screens = prob(1)
+	var/use_rare_screens = prob(5)		// 1% Chance for Rare Screens in /rare
+	var/use_joke_screens = prob(20) 	// 20% Chance for Joke Screens in /joke
 
-	for(var/S in provisional_title_screens)
-		var/list/L = splittext(S,"+")
-		if((L.len == 1 && (L[1] != "exclude" && L[1] != "blank.png"))|| (L.len > 1 && ((use_rare_screens && lowertext(L[1]) == "rare") || (lowertext(L[1]) == lowertext(SSmapping.config.map_name)))))
+	if(SSevents.holidays && SSevents.holidays[APRIL_FOOLS])
+		use_joke_screens = TRUE
+
+	if(use_rare_screens)
+		for(var/S in rare_provisional_title_screens)
+			title_screens += S
+		if(length(title_screens))
+			file_path = "[global.config.directory]/title_screens/images/rare/[pick(title_screens)]"
+	
+	else if(use_joke_screens)
+		for(var/S in joke_provisional_title_screens)
 			title_screens += S
+		if(length(title_screens))
+			file_path = "[global.config.directory]/title_screens/images/joke/[pick(title_screens)]"
 
-	if(length(title_screens))
-		file_path = "[global.config.directory]/title_screens/images/[pick(title_screens)]"
+	else
+		for(var/S in normal_provisional_title_screens)
+			title_screens += S
+		if(length(title_screens))
+			file_path = "[global.config.directory]/title_screens/images/normal/[pick(title_screens)]"
 
 	if(!file_path)
 		file_path = "icons/default_title.dmi"