Skip to content

Commit 4c27e53

Browse files
authored
Improve (#18)
1 parent ac033d7 commit 4c27e53

File tree

1 file changed

+23
-14
lines changed

1 file changed

+23
-14
lines changed

src/App/Helper/MinMaxHelper.php

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -81,24 +81,12 @@ private function appendCollectionDoc(CollectionDoc $doc, Constraint $constraint)
8181
} elseif ($constraint instanceof Assert\NotBlank && null === $doc->getMinItem()) {
8282
// Not blank so minimum 1 item
8383
$doc->setMinItem(1);
84-
}/* // Documentation does not mention array, counter to NotBlank constraint
84+
} /* Documentation does not mention array, counter to NotBlank constraint
8585
elseif ($constraint instanceof Assert\Blank && null === $doc->getMaxItem()) {
8686
// Blank so maximum 0 item
8787
$doc->setMaxItem(0);
8888
}*/
89-
if ($constraint instanceof Assert\GreaterThan || $constraint instanceof Assert\GreaterThanOrEqual) {
90-
$doc->setMinItem(
91-
$constraint instanceof Assert\GreaterThanOrEqual
92-
? $constraint->value
93-
: $constraint->value + 1
94-
);
95-
} elseif ($constraint instanceof Assert\LessThan || $constraint instanceof Assert\LessThanOrEqual) {
96-
$doc->setMaxItem(
97-
$constraint instanceof Assert\LessThanOrEqual
98-
? $constraint->value
99-
: $constraint->value - 1
100-
);
101-
}
89+
$this->appendLessGreaterThanMinMaxItem($doc, $constraint);
10290
}
10391

10492
/**
@@ -124,4 +112,25 @@ private function appendNumberMinMax(NumberDoc $doc, Constraint $constraint) : vo
124112
$doc->setMin($constraint->value);
125113
}
126114
}
115+
116+
/**
117+
* @param CollectionDoc $doc
118+
* @param Constraint $constraint
119+
*/
120+
private function appendLessGreaterThanMinMaxItem(CollectionDoc $doc, Constraint $constraint): void
121+
{
122+
if ($constraint instanceof Assert\GreaterThan || $constraint instanceof Assert\GreaterThanOrEqual) {
123+
$doc->setMinItem(
124+
$constraint instanceof Assert\GreaterThanOrEqual
125+
? $constraint->value
126+
: $constraint->value + 1
127+
);
128+
} elseif ($constraint instanceof Assert\LessThan || $constraint instanceof Assert\LessThanOrEqual) {
129+
$doc->setMaxItem(
130+
$constraint instanceof Assert\LessThanOrEqual
131+
? $constraint->value
132+
: $constraint->value - 1
133+
);
134+
}
135+
}
127136
}

0 commit comments

Comments
 (0)