Skip to content

Commit 41f8e12

Browse files
yoanmyoanm
authored
Improve (#12)
1 parent eadfb08 commit 41f8e12

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

‎src/App/Helper/ConstraintPayloadDocHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class ConstraintPayloadDocHelper
2222
* @param TypeDoc $doc
2323
* @param Constraint $constraint
2424
*/
25-
public function appendPayloadDoc(TypeDoc $doc, Constraint $constraint)
25+
public function appendPayloadDoc(TypeDoc $doc, Constraint $constraint) : void
2626
{
2727
if (!$this->hasPayloadDoc($constraint)) {
2828
return;

‎src/App/Helper/DocTypeHelper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function guess(array $constraintList) : TypeDoc
5151
*
5252
* @return TypeDoc|null
5353
*/
54-
protected function getDocFromTypeConstraintOrPayloadDocIfExist(array $constraintList)
54+
protected function getDocFromTypeConstraintOrPayloadDocIfExist(array $constraintList) : ?TypeDoc
5555
{
5656
$doc = null;
5757
// Check if a Type constraint exist or if a constraint have a type documentation
@@ -87,7 +87,7 @@ protected function getDocFromTypeConstraintOrPayloadDocIfExist(array $constraint
8787
*
8888
* @return TypeDoc|null
8989
*/
90-
private function normalizeType(string $type)
90+
private function normalizeType(string $type) : ?TypeDoc
9191
{
9292
if ('scalar' === $type) {
9393
return new ScalarDoc();

‎src/App/Helper/MinMaxHelper.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class MinMaxHelper
1717
* @param TypeDoc $doc
1818
* @param Constraint $constraint
1919
*/
20-
public function append(TypeDoc $doc, Constraint $constraint)
20+
public function append(TypeDoc $doc, Constraint $constraint) : void
2121
{
2222
if ($doc instanceof StringDoc) {
2323
$this->appendStringDoc($doc, $constraint);
@@ -32,7 +32,7 @@ public function append(TypeDoc $doc, Constraint $constraint)
3232
* @param StringDoc $doc
3333
* @param Constraint $constraint
3434
*/
35-
private function appendStringDoc(StringDoc $doc, Constraint $constraint)
35+
private function appendStringDoc(StringDoc $doc, Constraint $constraint) : void
3636
{
3737
if ($constraint instanceof Assert\Length) {
3838
if (null !== $constraint->min) {
@@ -54,7 +54,7 @@ private function appendStringDoc(StringDoc $doc, Constraint $constraint)
5454
* @param NumberDoc $doc
5555
* @param Constraint $constraint
5656
*/
57-
private function appendNumberDoc(NumberDoc $doc, Constraint $constraint)
57+
private function appendNumberDoc(NumberDoc $doc, Constraint $constraint) : void
5858
{
5959
$this->appendNumberMinMax($doc, $constraint);
6060

@@ -69,7 +69,7 @@ private function appendNumberDoc(NumberDoc $doc, Constraint $constraint)
6969
* @param CollectionDoc $doc
7070
* @param Constraint $constraint
7171
*/
72-
private function appendCollectionDoc(CollectionDoc $doc, Constraint $constraint)
72+
private function appendCollectionDoc(CollectionDoc $doc, Constraint $constraint) : void
7373
{
7474
if ($constraint instanceof Assert\Choice) {
7575
if (null !== $constraint->min) {
@@ -112,7 +112,7 @@ private function appendCollectionDoc(CollectionDoc $doc, Constraint $constraint)
112112
* @param NumberDoc $doc
113113
* @param Constraint $constraint
114114
*/
115-
private function appendNumberMinMax(NumberDoc $doc, Constraint $constraint)
115+
private function appendNumberMinMax(NumberDoc $doc, Constraint $constraint) : void
116116
{
117117
if ($constraint instanceof Assert\Range) {
118118
if (null !== $constraint->min) {

‎src/App/Helper/StringDocHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class StringDocHelper
1717
*
1818
* @throws \ReflectionException
1919
*/
20-
public function append(TypeDoc $doc, Constraint $constraint)
20+
public function append(TypeDoc $doc, Constraint $constraint) : void
2121
{
2222
// If format already defined or type is defined and is not a string nor scalar => give up
2323
if (!$doc instanceof StringDoc) {

‎src/App/Helper/TypeGuesser.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class TypeGuesser
2222
*
2323
* @return TypeDoc|null
2424
*/
25-
public function guessTypeFromConstraintList(array $constraintList)
25+
public function guessTypeFromConstraintList(array $constraintList) : ?TypeDoc
2626
{
2727
$doc = $abstractTypeFound = null;
2828
foreach ($constraintList as $constraint) {
@@ -50,7 +50,7 @@ public function guessTypeFromConstraintList(array $constraintList)
5050
*
5151
* @return TypeDoc|null
5252
*/
53-
protected function guessTypeFromConstraint(Constraint $constraint)
53+
protected function guessTypeFromConstraint(Constraint $constraint) : ?TypeDoc
5454
{
5555
if (null !== ($type = $this->guessPrimaryTypeFromConstraint($constraint))) {
5656
return $type;
@@ -86,7 +86,7 @@ private function isAbstractType(TypeDoc $doc) : bool
8686
*
8787
* @return null|ArrayDoc|BooleanDoc|ObjectDoc|ScalarDoc|StringDoc
8888
*/
89-
private function guessPrimaryTypeFromConstraint(Constraint $constraint)
89+
private function guessPrimaryTypeFromConstraint(Constraint $constraint) : ?TypeDoc
9090
{
9191
static $stringConstraintClassList = [
9292
Assert\Length::class, // << Applied on string only
@@ -140,7 +140,7 @@ private function guessPrimaryTypeFromConstraint(Constraint $constraint)
140140
*
141141
* @return ScalarDoc|StringDoc
142142
*/
143-
private function guessDateTimeType(Assert\DateTime $constraint)
143+
private function guessDateTimeType(Assert\DateTime $constraint) : TypeDoc
144144
{
145145
if ('U' === $constraint->format) {
146146
return new ScalarDoc();// Don't know if value will be an number as string or as integer
@@ -154,7 +154,7 @@ private function guessDateTimeType(Assert\DateTime $constraint)
154154
*
155155
* @return ArrayDoc|ObjectDoc
156156
*/
157-
private function guestCollectionType(Assert\Collection $constraint)
157+
private function guestCollectionType(Assert\Collection $constraint) : TypeDoc
158158
{
159159
// If only integer => array, else object
160160
$integerKeyList = array_filter(array_keys($constraint->fields), 'is_int');

‎src/Infra/Transformer/ConstraintToParamsDocTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ class_uses($object)
230230
return count(array_intersect($actualClassList, $classList)) > 0;
231231
}
232232

233-
private function addToAllowedValueListIfNotExist(TypeDoc $doc, $value)
233+
private function addToAllowedValueListIfNotExist(TypeDoc $doc, $value) : void
234234
{
235235
if (!in_array($value, $doc->getAllowedValueList(), true)) {
236236
$doc->addAllowedValue($value);

0 commit comments

Comments
 (0)