Chore: Type hints in ServerAPI and global api functions #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ayon_api/server_api.py
kalisp
approved these changes
Dec 11, 2024
Member
kalisp
left a comment
kalisp
left a comment
There was a problem hiding this comment.
Looks good. Doesn't break anything.
iLLiCiTiT
deleted the
enhancement/175-type-hints-in-serverapi-and-global-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Added typehints to most of ServerAPI functions and in public api functions.
Additional review information
It is a lot of changes, I've discovered multiple unexpected behaviors in the code, different order od arguments in some getter, different return output for create methods, those will come in future PRs.
I didn't fill typehints to some deprecated arguments. I've tried my best, hopefully all necessary is filled.
Testing notes: