🚨 fix lint rule

Author: ymyqwe

.eslintrc

@@ -9,6 +9,10 @@
     "no-console": 1,
     "react/prop-types": 0,
     "no-undef": 0,
-    "@typescript-eslint/consistent-type-definitions": ["error", "interface"]
+    "@typescript-eslint/consistent-type-definitions": ["error", "interface"],
+    "require-jsdoc": 1,
+    "max-len": [1, { "code": 200 }],
+    "object-curly-spacing": ["warn", "always"],
+    "comma-dangle": [1, "never"]
   }
 }

.eslintrc.js

@@ -9,6 +9,10 @@ module.exports = {
     'no-console': 1,
     'react/prop-types': 0,
     'no-undef': 0,
-    '@typescript-eslint/consistent-type-definitions': ['error', 'interface']
+    '@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
+    'require-jsdoc': 1,
+    'max-len': [1, { code: 200 }],
+    'object-curly-spacing': ['warn', 'always'],
+    'comma-dangle': [1, 'never']
   }
 };

server.js

@@ -6,15 +6,18 @@ var openBrowsers = require('open-browsers');
 
 // log
 const log4js = require('log4js');
-log4js.addLayout('json', config => function (logEvent) {
-  logEvent.data = logEvent.data[0];
-  return JSON.stringify(logEvent) + config.separator;
-});
+log4js.addLayout(
+  'json',
+  (config) =>
+    function(logEvent) {
+      logEvent.data = logEvent.data[0];
+      return JSON.stringify(logEvent) + config.separator;
+    }
+);
 const logConf = require('./conf/log.conf');
 log4js.configure(logConf);
 const logger = log4js.getLogger('chatLog');
 
-
 // 开发模式热更新
 if (process.env.NODE_ENV !== 'production') {
   var webpack = require('webpack');
@@ -59,21 +62,21 @@ io.on('connection', function(socket) {
     socket.id = obj.uid;
 
     // 如果没有这个用户，那么在线人数+1，将其添加进在线用户
-    if (!onlineUsers.hasOwnProperty(obj.uid)) {
+    if (!onlineUsers[obj.uid]) {
       onlineUsers[obj.uid] = obj.username;
       onlineCount++;
     }
 
     // 向客户端发送登陆事件，同时发送在线用户、在线人数以及登陆用户
     io.emit('login', { onlineUsers: onlineUsers, onlineCount: onlineCount, user: obj });
-    logger.info({ socketId: socket.id, ip: socket.request.connection.remoteAddress, user: obj.username, event: 'in', message: obj.username + '加入了群聊'});
+    logger.info({ socketId: socket.id, ip: socket.request.connection.remoteAddress, user: obj.username, event: 'in', message: obj.username + '加入了群聊' });
     console.log(obj.username + '加入了群聊');
   });
 
   // 监听客户端的断开连接
   socket.on('disconnect', function() {
     // 如果有这个用户
-    if (onlineUsers.hasOwnProperty(socket.id)) {
+    if (onlineUsers[socket.id]) {
       var obj = { uid: socket.id, username: onlineUsers[socket.id] };
 
       // 删掉这个用户，在线人数-1
@@ -82,15 +85,15 @@ io.on('connection', function(socket) {
 
       // 向客户端发送登出事件，同时发送在线用户、在线人数以及登出用户
       io.emit('logout', { onlineUsers: onlineUsers, onlineCount: onlineCount, user: obj });
-      logger.info({ socketId: socket.id, ip: socket.request.connection.remoteAddress, user: obj.username, event: 'out', message: obj.username + '退出了群聊'});
+      logger.info({ socketId: socket.id, ip: socket.request.connection.remoteAddress, user: obj.username, event: 'out', message: obj.username + '退出了群聊' });
       console.log(obj.username + '退出了群聊');
     }
   });
 
   // 监听客户端发送的信息
   socket.on('message', function(obj) {
     io.emit('message', obj);
-    logger.info({ socketId: socket.id, ip: socket.request.connection.remoteAddress, user: obj.username, event: 'chat', message: obj.username + '说:' + obj.message});
+    logger.info({ socketId: socket.id, ip: socket.request.connection.remoteAddress, user: obj.username, event: 'chat', message: obj.username + '说:' + obj.message });
     console.log(obj.username + '说:' + obj.message);
   });
 });

src/components/ChatRoom.tsx

@@ -65,7 +65,7 @@ const ChatRoom = (props) => {
     let userhtml = '';
     let separator = '';
     for (const key in users) {
-      if (users.hasOwnProperty(key)) {
+      if (users.key) {
         userhtml += separator + users[key];
         separator = '、';
       }

src/index.tsx

@@ -3,8 +3,8 @@ import ReactDOM from 'react-dom';
 import App from './container/App';
 import { ContextProvider } from './context/index';
 ReactDOM.render(
-  <ContextProvider>
-    <App />
-  </ContextProvider>,
-  document.getElementById('app')
+    <ContextProvider>
+      <App />
+    </ContextProvider>,
+    document.getElementById('app')
 );