Skip to content
This repository was archived by the owner on Sep 27, 2022. It is now read-only.

Resolve "facets having mincount of 0 are not supported..." #154

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Resolve "facets having mincount of 0 are not supported..." #154

merged 3 commits into from
Mar 10, 2022

Conversation

froboy
Copy link
Contributor

@froboy froboy commented Mar 9, 2022

Resolves #153

To test:

  • drush updb
  • completely rebuild solr index: drush sapi-r && drush sapi-i
  • observe /activity-finder-v4 doesn't throw the error in the issue
  • test age facets and ensure they work as expected.

@froboy froboy marked this pull request as ready for review March 9, 2022 17:39
@@ -223,7 +223,7 @@ function openy_activity_finder_update_8402() {
/**
* Update configs for search index.
*/
function openy_activity_finder_update_8403() {
function openy_activity_finder_update_8404() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of renaming old function, let's introduce a new one and call old from it @froboy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion @podarok. I elaborated on the existing function to make it a little more flexible.

@podarok podarok merged commit 5625c4a into ymcatwincities:4.x Mar 10, 2022
@froboy froboy deleted the patch-3 branch March 14, 2022 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solr >=7 errors on field_session_min_age/max_age
2 participants